[FOP-2785] inconsistent method name "make"

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.5
• Assignee: Unassigned
• Reporter: KuiLIU
• Created: 17/Apr/18 11:46
• Updated: 17/Apr/18 13:27
• Resolved: 17/Apr/18 13:27

Description

The method seems to find an appropriate "Property" related to the fo.getNameId().
Thus, identifier "find" should be better than "make".

   /**
     * Set default precedence according to the parent FObj
     *
     * {@inheritDoc}
     */
     public Property make(PropertyList propertyList) throws PropertyException {
         FObj fo = propertyList.getFObj();
         switch (fo.getNameId()) {
         case Constants.FO_TABLE:
             return num6;
         case Constants.FO_TABLE_CELL:
             return num5;
         case Constants.FO_TABLE_COLUMN:
             return num4;
         case Constants.FO_TABLE_ROW:
             return num3;
         case Constants.FO_TABLE_BODY:
             return num2;
         case Constants.FO_TABLE_HEADER:
             return num1;
         case Constants.FO_TABLE_FOOTER:
             return num0;
         default:
             return null;
         }
     }