[FOP-2732] Collection added to itself

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: JC
• Created: 14/Aug/17 19:12
• Updated: 14/Aug/17 19:12

Description

Hi

In a recent github mirro, I've found the following suspicious code.
Branch: master
Path: fop-core/src/main/java/org/apache/fop/afp/goca/AbstractGraphicsDrawingOrderContainer.java

...
 39     protected List objects = new java.util.ArrayList();
...
 86     public void addAll(AbstractGraphicsDrawingOrderContainer graphicsContainer) {
 87         Collection objects = graphicsContainer.getObjects();
 88         objects.addAll(objects);
 89     }

In Line 88, should `objects.addAll' be `this.objects.addAll? Since this method in an abstract class, it might not be an issue if this method is overridden. However, I wanted to report this just in case.

Thanks!