[FOP-2502] [PATCH] Rendering dashed lines with zero length components

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.5
• Component/s: renderer/pdf
• Assignee: Unassigned
• Reporter: Jan Tošovský
• Created: 18/Jul/15 18:39
• Updated: 13/Jul/18 20:20

Description

The current PDF renderer may produce following dashed line segments:

[0 0] 0 d

This combination puzzles Adobe Reader which stops rendering the remaining content.

I suggest avoiding this combination by a simple check in setDashLine() method in PDFGraphicsPainter.java:

        public PDFContentGeneratorHelper setDashLine(float first, float... rest) {
            StringBuilder sb = new StringBuilder(format(first));
            for (float unit : rest) {
                sb.append(" ").append(format(unit));
            }
            if (sb.toString().equals("0 0")) {
                sb = new StringBuilder();
            }
            sb.insert(0, "[");
            sb.append("] 0 d ");
            
            generator.add(sb.toString());
            return this;
        }

The code above produces the following code instead, which is Ok.

[] 0 d