[FOP-2273] Stroke miter limit is not clamped when writing PDFs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.2
• Component/s: renderer/pdf
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Max Gilead
• Created: 11/Jul/13 12:30
• Updated: 11/Apr/17 11:10
• Resolved: 12/Jul/13 22:03

Description

org.apache.fop.svg.PDFGraphics2D line 1240 (as of SVN revision 148001 [1]) is:
float ml = bs.getMiterLimit();
but should be (or equivalent):
float ml = Math.max(1.0f, bs.getMiterLimit());

Acrobat Reader (on all platforms) refuses to load graphics data after encountering miter limit < 1.0 and reports an error.

I can't find a reference to the valid range in the PDF spec but Inkscape also had a problem with values less than 1.0 [2] and SVG spec mandates values >= 1.0 as well [3] so clamping the value to 1.0 or more seems like the right thing to do.

[1] http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphics2D.java?revision=1480018&view=markup
[2] http://webcache.googleusercontent.com/search?q=cache:RHSt5Wk7-uQJ:inkscape-forum.andreas-s.net/topic/71990+&cd=7&hl=en&ct=clnk&gl=uk&client=firefox-beta
[3] http://www.w3.org/TR/SVG11/painting.html#StrokeMiterlimitProperty