Fop
  1. Fop
  2. FOP-2082

simple bug in HyphenationTreeCache

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: layout/unqualified
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: PC
    • External issue ID:
      53458

      Description

      in method constructUserKey() i found this code near line 82:

      if (hyphPatNames != null)

      { String key = constructLlccKey(lang, country); key.replace('_', '-'); <<<<<<<< ======= !!!! userKey = (String) hyphPatNames.get(key); }

      return userKey;

      it should be
      key = key.replace('_', '-');

      the code as it is now is without effect.

        Activity

        Hide
        dieter von holten added a comment -

        i found that a specific findbugs-check for this is disabled in file 'findbugs-exclude.xml'.

        findbugs is right - the code is wrong

        Show
        dieter von holten added a comment - i found that a specific findbugs-check for this is disabled in file 'findbugs-exclude.xml'. findbugs is right - the code is wrong
        Hide
        Glenn Adams added a comment -

        (In reply to comment #1)
        > i found that a specific findbugs-check for this is disabled in file
        > 'findbugs-exclude.xml'.
        >
        > findbugs is right - the code is wrong

        thanks for tracking this down; that is one of the problems with generating exclusions automatically and not going back to review them; reviewing the findbugs exclusions remains a TBD;

        could you attach a minimal regression test we can add to test the condition addressed by this fix?

        Show
        Glenn Adams added a comment - (In reply to comment #1) > i found that a specific findbugs-check for this is disabled in file > 'findbugs-exclude.xml'. > > findbugs is right - the code is wrong thanks for tracking this down; that is one of the problems with generating exclusions automatically and not going back to review them; reviewing the findbugs exclusions remains a TBD; could you attach a minimal regression test we can add to test the condition addressed by this fix?
        Hide
        Glenn Adams added a comment -

        patch applied at http://svn.apache.org/viewvc?rev=1353320&view=rev

        thanks dieter! please review and close if satisfied... also, if you wish to submit a test case, it would be appreciated...

        Show
        Glenn Adams added a comment - patch applied at http://svn.apache.org/viewvc?rev=1353320&view=rev thanks dieter! please review and close if satisfied... also, if you wish to submit a test case, it would be appreciated...
        Hide
        dieter von holten added a comment -

        when you fix the two typos of 'hyphneation' in the same file i'd completly happy.
        providing a testcase for this might be tricky - the bug is 'deep inside' and i have no idea how to influence hyphenation in fop.

        Show
        dieter von holten added a comment - when you fix the two typos of 'hyphneation' in the same file i'd completly happy. providing a testcase for this might be tricky - the bug is 'deep inside' and i have no idea how to influence hyphenation in fop.
        Hide
        Glenn Adams added a comment -

        (In reply to comment #4)
        > when you fix the two typos of 'hyphneation' in the same file i'd completly
        > happy.

        done!

        > providing a testcase for this might be tricky - the bug is 'deep inside' and
        > i have no idea how to influence hyphenation in fop.

        well, if you have any thoughts on this in the future, please say so

        Show
        Glenn Adams added a comment - (In reply to comment #4) > when you fix the two typos of 'hyphneation' in the same file i'd completly > happy. done! > providing a testcase for this might be tricky - the bug is 'deep inside' and > i have no idea how to influence hyphenation in fop. well, if you have any thoughts on this in the future, please say so

          People

          • Assignee:
            fop-dev
            Reporter:
            dieter von holten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development