Uploaded image for project: 'FOP'
  1. FOP
  2. FOP-1986

[PATCH] Build.xml simplification and JUnit regex

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: None
    • Component/s: unqualified
    • Labels:
      None
    • Environment:
      Operating System: Linux
      Platform: PC
    • External issue ID:
      52136

      Description

      This patch changes the build.xml file to reduce some of the code-duplication. It also introduces a regex for finding the Junit test files, the reason I've done this is because some of the tests were being ignored because they didn't appear in a TestSuite. I also think the output produced by junit on the command line more readable.

      However, in order to use a regex (**/*TestCase.java), this means that any class in the test file that isn't intended to run (helper files or abstract classes) cannot be called *TestCase.java. I think that's a fairly well established tradition.

      1. junit-regex.patch
        324 kB
        Mehdi Houshmand

        Activity

        Hide
        vhennebert Vincent Hennebert added a comment -

        Patch applied in rev. 1198853:
        http://svn.apache.org/viewvc?revision=1198853&view=revision

        I inferred from the patch the files that were renamed, in order to preserve Subversion history. In the future it would be helpful if you could list the files that you renamed and to what.

        I removed the junit-full target which no longer has a utility.

        Thanks!
        Vincent

        Show
        vhennebert Vincent Hennebert added a comment - Patch applied in rev. 1198853: http://svn.apache.org/viewvc?revision=1198853&view=revision I inferred from the patch the files that were renamed, in order to preserve Subversion history. In the future it would be helpful if you could list the files that you renamed and to what. I removed the junit-full target which no longer has a utility. Thanks! Vincent
        Hide
        med1985@gmail.com Mehdi Houshmand added a comment -

        Attachment junit-regex.patch has been added with description: Junit-regex patch

        Show
        med1985@gmail.com Mehdi Houshmand added a comment - Attachment junit-regex.patch has been added with description: Junit-regex patch

          People

          • Assignee:
            fop-dev@xmlgraphics.apache.org fop-dev
            Reporter:
            med1985@gmail.com Mehdi Houshmand
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development