[FOP-1898] KnuthSequence documentation?

• Type: Bug
• Status: Open
• Resolution: Unresolved
• Affects Version/s: 2.5
• Component/s: layout/unqualified
• Environment: Operating System: All; Platform: All
• External issue ID: 50725
• Assignee: Unassigned
• Reporter: Andreas L. Delmelle
• Created: 06/Feb/11 12:17
• Updated: 16/Dec/12 08:22

Description

Attached is a patch against fop.layoutmgr.KnuthSequence, which takes care of a TODO (Do not extend ArrayList) by implementing the List interface via proxy methods to a member list.

Reason this is not committed yet, is that I wanted to go a step further and add type safety to this class, but noticed that this is currently impossible.
The explanation is also added in a new TODO: there is an inconsistency (or at least incongruency) between block-layout and inline-layout. Block-layout works mainly with KnuthSequences as List<ListElement> where inline-layout seems to expect List<KnuthSequence>...

Suggestions? Ideas? I would like to see those aligned, and in theory, once KnuthSequence implements List, it is free to extend ListElement, if that would be appropriate. The other way around could also make sense: consider each ListElement as a KnuthSequence of a single element. Although that would require some more refactoring, since we have to extract the KnuthSequence/List interface before ListElement can implement it.