FOP
  1. FOP
  2. FOP-1894

[PATCH] AFP TLEs and NOPs not in the order described in the FO

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: unqualified
    • Labels:
      None
    • Environment:
      Operating System: Linux
      Platform: PC
    • External issue ID:
      50705

      Description

      I'll include a test case FO and before and after AFP documents. The issues is as follows; if you define a combination of TLEs and NOPs in the simple-page-master, regardless of the order, FOP will print the TLEs first then the NOPs.

      The reason is because they're held in different ArrayLists in o.a.f.afp.modca.AbstractPageObject. Why it has been done this way? I don't know, there may be a perfectly good reason I'm not aware of. But since they derive from a common ancestor (AbstractStructuredObject), I've removed the list that stores the TLEs separately, so that TLEs and NOPs are stored in the same ArrayList. This means that the TLEs and NOPs are printed in the order they appear in the FO.

      1. patch.diff
        4 kB
        Mehdi Houshmand
      2. test.fo
        3 kB
        Mehdi Houshmand

        Activity

        Hide
        Mehdi Houshmand added a comment -

        Attachment patch.diff has been added with description: Patch to fix out of order printing of TLEs in AFP

        Show
        Mehdi Houshmand added a comment - Attachment patch.diff has been added with description: Patch to fix out of order printing of TLEs in AFP
        Hide
        Mehdi Houshmand added a comment -

        This is the test case for this bug

        Show
        Mehdi Houshmand added a comment - This is the test case for this bug
        Hide
        Mehdi Houshmand added a comment -

        Attachment test.fo has been added with description: Test case

        Show
        Mehdi Houshmand added a comment - Attachment test.fo has been added with description: Test case
        Hide
        Mehdi Houshmand added a comment -

        On second thoughts, attaching before and after AFPs seems redundant, if anyone requests them, I'll be happy to post them here

        Show
        Mehdi Houshmand added a comment - On second thoughts, attaching before and after AFPs seems redundant, if anyone requests them, I'll be happy to post them here
        Hide
        Jeremias Maerki added a comment -
        Show
        Jeremias Maerki added a comment - Patch applied. Thanks, Mehdi! http://svn.apache.org/viewvc?rev=1067109&view=rev
        Hide
        Glenn Adams added a comment -

        batch transition to closed; if someone wishes to restore one of these to resolved in order to perform a verification step, then feel free to do so

        Show
        Glenn Adams added a comment - batch transition to closed; if someone wishes to restore one of these to resolved in order to perform a verification step, then feel free to do so

          People

          • Assignee:
            fop-dev
            Reporter:
            Mehdi Houshmand
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development