Fop
  1. Fop
  2. FOP-1704

Percentages not working for provisional-distance-between-starts

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 0.95
    • Fix Version/s: None
    • Component/s: layout/unqualified
    • Labels:
      None
    • Environment:
      Operating System: Windows Vista
      Platform: PC
    • External issue ID:
      47835

      Description

      According to the spec, percentages are allowed for
      provisional-distance-between-starts, but FOP doesn't handle it correctly.

      1. FOPropertyMapping.patch
        0.5 kB
        Jonathan Levinson
      2. pdbs.fo
        2 kB
        Eric Amick

        Activity

        Hide
        Glenn Adams added a comment -

        batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

        Show
        Glenn Adams added a comment - batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed
        Hide
        Vincent Hennebert added a comment -

        Fixed in revision 824668:
        http://svn.apache.org/viewvc?rev=824668&view=rev
        Thanks for the patch!

        Vincent

        Show
        Vincent Hennebert added a comment - Fixed in revision 824668: http://svn.apache.org/viewvc?rev=824668&view=rev Thanks for the patch! Vincent
        Hide
        Venkat Reddy added a comment -

        (In reply to comment #2)
        > According to standard:
        > The "provisional-distance-between-start" is specified as a percentage of the
        > inline progression dimension of the closet ancestor block-area.
        > To its definition in FOPPropertyMapping.java I added the following:
        > m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH);
        > I ran the JUNIT tests and no new problems resulted.
        > I generated the PDF with the new fop.jar and the percentage distances seemed
        > correct.

        Yes. This patch is working perfectly. I have tested the orginal pdabs.fo with provisional-distance-between-start="50%", the space created between elements.
        Excellent.

        Show
        Venkat Reddy added a comment - (In reply to comment #2) > According to standard: > The "provisional-distance-between-start" is specified as a percentage of the > inline progression dimension of the closet ancestor block-area. > To its definition in FOPPropertyMapping.java I added the following: > m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH); > I ran the JUNIT tests and no new problems resulted. > I generated the PDF with the new fop.jar and the percentage distances seemed > correct. Yes. This patch is working perfectly. I have tested the orginal pdabs.fo with provisional-distance-between-start="50%", the space created between elements. Excellent.
        Hide
        Jonathan Levinson added a comment -

        According to standard:

        The "provisional-distance-between-start" is specified as a percentage of the inline progression dimension of the closet ancestor block-area.

        To its definition in FOPPropertyMapping.java I added the following:

        m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH);

        I ran the JUNIT tests and no new problems resulted.

        I generated the PDF with the new fop.jar and the percentage distances seemed correct.

        Show
        Jonathan Levinson added a comment - According to standard: The "provisional-distance-between-start" is specified as a percentage of the inline progression dimension of the closet ancestor block-area. To its definition in FOPPropertyMapping.java I added the following: m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH); I ran the JUNIT tests and no new problems resulted. I generated the PDF with the new fop.jar and the percentage distances seemed correct.
        Hide
        Jonathan Levinson added a comment -

        Attachment FOPropertyMapping.patch has been added with description: Let provisional-distance-between-starts act correctly as percentage

        Show
        Jonathan Levinson added a comment - Attachment FOPropertyMapping.patch has been added with description: Let provisional-distance-between-starts act correctly as percentage
        Hide
        Jonathan Levinson added a comment -

        This is a patch to FOPPropertyMapping.java.

        Show
        Jonathan Levinson added a comment - This is a patch to FOPPropertyMapping.java.
        Hide
        Eric Amick added a comment -

        Attachment pdbs.fo has been added with description: FO demonstrating bug. The first list uses percentage, the second doesn't.

        Show
        Eric Amick added a comment - Attachment pdbs.fo has been added with description: FO demonstrating bug. The first list uses percentage, the second doesn't.

          People

          • Assignee:
            fop-dev
            Reporter:
            Eric Amick
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development