[FOP-1558] Better support for overriding default LayoutManagerMaker needed

• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 0.94
• Component/s: layout/unqualified
• Environment: Operating System: All; Platform: All
• External issue ID: 45470
• Assignee: fop-dev
• Reporter: Rainer Langbehn
• Created: 23/Jul/08 12:38
• Updated: 23/Jul/08 12:53
• Resolved: 01/Apr/12 07:01

Description

I have the requirement to replace the default BlockContainerLayoutManagerMaker with my own implementation. After searching the code base I think the suggested way is by using the setLayoutManagerMakerOverride(LayoutManagerMaker) method of the FopFactory to override the default LayoutManagerMaker implementation.

My own LayoutManagerMaker is a subclass of the default LayoutManagerMapping.
Unfortunately, 'cause the map of LayoutManagerMakers is private and no protected setter is given to change the default mapping set during initialize(), one has to provide a second map of LayoutManagerMakers and duplicate a lot of code to tell fop to use this new mapping.

My suggestion:
Either make the map of LayoutManagerMakers protected or preferably provide a protected setter to change the default mapping.

Thanks in advance
Rainer