FOP
  1. FOP
  2. FOP-1144

[PATCH] cleanup of rgb() and implementation of system-color()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: fo/unqualified
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • External issue ID:
      38618

      Description

      Dear FOP developers,

      I am really happy with the new FOP. It finally renders my documents the way I
      like it.

      I would love to see the red spots on the compliance chart disappear, and I
      decided to help out.

      This patch

      • removes functionality that was duplicated (in RGBColorFunction and
        ColorTypeProperty)
      • Adds better error handling to ColorTypeProperty
      • Adds support for the system-color() function

      I hope I follwed all the necessary steps.

      Max

      1. color-cleanup.diff
        11 kB
        Max Berger
      2. color.fo
        0.9 kB
        Max Berger

        Activity

        Hide
        Glenn Adams added a comment -

        batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

        Show
        Glenn Adams added a comment - batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed
        Hide
        Jeremias Maerki added a comment -

        (In reply to comment #0)
        > Dear FOP developers,
        >
        > I am really happy with the new FOP. It finally renders my documents the way I
        > like it.

        I'm happy to hear that.

        > I would love to see the red spots on the compliance chart disappear, and I
        > decided to help out.

        That's the spirit!!! Are there more guys like you where you come from?

        > This patch
        > - removes functionality that was duplicated (in RGBColorFunction and
        > ColorTypeProperty)
        >
        > - Adds better error handling to ColorTypeProperty
        >
        > - Adds support for the system-color() function
        >
        > I hope I follwed all the necessary steps.

        Good stuff. I modified your patch just a little to fix some Checkstyle issues
        and to handle the "FIXME" you had in the patch. I also added your FO file as a
        test case to the repo.

        New files normally require that you have an CLA [1] on file with the ASF, but
        since the addition was such a trivial class I consider it subject to chapter 5
        in the ALv2 like the rest of the patch. I hope that was only the first of your
        patches. If you start doing bigger changes I would like you to submit an CLA [1]
        to the ASF. If you have any questions about that, please ask.

        [1] http://www.apache.org/licenses/#clas

        So, patch applied. Thanks a lot!
        http://svn.apache.org/viewcvs?rev=377045&view=rev

        Show
        Jeremias Maerki added a comment - (In reply to comment #0) > Dear FOP developers, > > I am really happy with the new FOP. It finally renders my documents the way I > like it. I'm happy to hear that. > I would love to see the red spots on the compliance chart disappear, and I > decided to help out. That's the spirit!!! Are there more guys like you where you come from? > This patch > - removes functionality that was duplicated (in RGBColorFunction and > ColorTypeProperty) > > - Adds better error handling to ColorTypeProperty > > - Adds support for the system-color() function > > I hope I follwed all the necessary steps. Good stuff. I modified your patch just a little to fix some Checkstyle issues and to handle the "FIXME" you had in the patch. I also added your FO file as a test case to the repo. New files normally require that you have an CLA [1] on file with the ASF, but since the addition was such a trivial class I consider it subject to chapter 5 in the ALv2 like the rest of the patch. I hope that was only the first of your patches. If you start doing bigger changes I would like you to submit an CLA [1] to the ASF. If you have any questions about that, please ask. [1] http://www.apache.org/licenses/#clas So, patch applied. Thanks a lot! http://svn.apache.org/viewcvs?rev=377045&view=rev
        Hide
        Max Berger added a comment -

        Attachment color.fo has been added with description: Short .fo file that tests colors

        Show
        Max Berger added a comment - Attachment color.fo has been added with description: Short .fo file that tests colors
        Hide
        Max Berger added a comment -

        Attachment color-cleanup.diff has been added with description: Proposed Patch for color support

        Show
        Max Berger added a comment - Attachment color-cleanup.diff has been added with description: Proposed Patch for color support
        Max Berger created issue -

          People

          • Assignee:
            fop-dev
            Reporter:
            Max Berger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development