Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.0.0, v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: Configuration
    • Labels:
    • Release Note:
      Flume startup command "agent" replaces the "node" command.
    1. FLUME-999-3.patch
      2 kB
      Mike Percy
    2. FLUME-999-2.patch
      2 kB
      Mike Percy
    3. FLUME-999.patch
      2 kB
      Alexander Alten-Lorenz

      Activity

      Hide
      Alexander Alten-Lorenz added a comment -

      I will submit some patches over the week

      Show
      Alexander Alten-Lorenz added a comment - I will submit some patches over the week
      Hide
      Alexander Alten-Lorenz added a comment - - edited

      patch _1 to fit changes from FLUME-1005

      Show
      Alexander Alten-Lorenz added a comment - - edited patch _1 to fit changes from FLUME-1005
      Hide
      Brock Noland added a comment -

      Hi,

      Flume uses: reviews.apache.org for code reviews.

      Basically what you do, at leas to my understanding, is post the patch on reviews.apache.org, make you put the JIRA #, and then also post the patch on the JIRA itself.

      Brock

      Show
      Brock Noland added a comment - Hi, Flume uses: reviews.apache.org for code reviews. Basically what you do, at leas to my understanding, is post the patch on reviews.apache.org, make you put the JIRA #, and then also post the patch on the JIRA itself. Brock
      Hide
      Alexander Alten-Lorenz added a comment -

      Submitted to review (initial patch)
      https://reviews.apache.org/r/4050/

      _1 not submitted till now, because init script has changed and I want to check them again.

      Show
      Alexander Alten-Lorenz added a comment - Submitted to review (initial patch) https://reviews.apache.org/r/4050/ _1 not submitted till now, because init script has changed and I want to check them again.
      Hide
      Brock Noland added a comment -

      Cool! When you are ready, if you add FLUME-999 to the "bug" section of the review will be linked to this JIRA.

      Show
      Brock Noland added a comment - Cool! When you are ready, if you add FLUME-999 to the "bug" section of the review will be linked to this JIRA.
      Hide
      Alexander Alten-Lorenz added a comment -

      Patch updated, works now with FLUME-1005

      https://reviews.apache.org/r/4105/

      Show
      Alexander Alten-Lorenz added a comment - Patch updated, works now with FLUME-1005 https://reviews.apache.org/r/4105/
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4105/
      -----------------------------------------------------------

      (Updated 2012-02-29 10:10:08.301927)

      Review request for Flume.

      Changes
      -------

      change terms into agent, testet with patch FLUME-1005

      Summary
      -------

      Patch to fit the term agent, FLUME-999

      This addresses bug FLUME-999.
      https://issues.apache.org/jira/browse/FLUME-999

      Diffs


      bin/flume-ng 0796a5b

      Diff: https://reviews.apache.org/r/4105/diff

      Testing
      -------

      Thanks,

      Alexander

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4105/ ----------------------------------------------------------- (Updated 2012-02-29 10:10:08.301927) Review request for Flume. Changes ------- change terms into agent, testet with patch FLUME-1005 Summary ------- Patch to fit the term agent, FLUME-999 This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs bin/flume-ng 0796a5b Diff: https://reviews.apache.org/r/4105/diff Testing ------- Thanks, Alexander
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4105/#review6256
      -----------------------------------------------------------

      Thanks for the patch Alex. Some feedback:

      • Please rebase it on the trunk.
      • Please do not remove the term "node" but instead it should be deprecated. this means that it should now be shown in the usage/help output, but should continue to work with a warning that it is deprecated.

      Thanks!

      • Arvind

      On 2012-02-29 10:10:08, Alexander Alten-Lorenz wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4105/

      -----------------------------------------------------------

      (Updated 2012-02-29 10:10:08)

      Review request for Flume.

      Summary

      -------

      Patch to fit the term agent, FLUME-999

      This addresses bug FLUME-999.

      https://issues.apache.org/jira/browse/FLUME-999

      Diffs

      -----

      bin/flume-ng 0796a5b

      Diff: https://reviews.apache.org/r/4105/diff

      Testing

      -------

      Thanks,

      Alexander

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4105/#review6256 ----------------------------------------------------------- Thanks for the patch Alex. Some feedback: Please rebase it on the trunk. Please do not remove the term "node" but instead it should be deprecated. this means that it should now be shown in the usage/help output, but should continue to work with a warning that it is deprecated. Thanks! Arvind On 2012-02-29 10:10:08, Alexander Alten-Lorenz wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4105/ ----------------------------------------------------------- (Updated 2012-02-29 10:10:08) Review request for Flume. Summary ------- Patch to fit the term agent, FLUME-999 This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs ----- bin/flume-ng 0796a5b Diff: https://reviews.apache.org/r/4105/diff Testing ------- Thanks, Alexander
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4577/
      -----------------------------------------------------------

      Review request for Flume.

      Summary
      -------

      I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.

      This addresses bug FLUME-999.
      https://issues.apache.org/jira/browse/FLUME-999

      Diffs


      bin/flume-ng a31f171

      Diff: https://reviews.apache.org/r/4577/diff

      Testing
      -------

      Tested invocation using both "node" and "agent".

      Thanks,

      Mike

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/ ----------------------------------------------------------- Review request for Flume. Summary ------- I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature. This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4577/diff Testing ------- Tested invocation using both "node" and "agent". Thanks, Mike
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4577/#review6599
      -----------------------------------------------------------

      Ship it!

      +1

      • Arvind

      On 2012-03-30 23:23:09, Mike Percy wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4577/

      -----------------------------------------------------------

      (Updated 2012-03-30 23:23:09)

      Review request for Flume.

      Summary

      -------

      I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.

      This addresses bug FLUME-999.

      https://issues.apache.org/jira/browse/FLUME-999

      Diffs

      -----

      bin/flume-ng a31f171

      Diff: https://reviews.apache.org/r/4577/diff

      Testing

      -------

      Tested invocation using both "node" and "agent".

      Thanks,

      Mike

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/#review6599 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-03-30 23:23:09, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/ ----------------------------------------------------------- (Updated 2012-03-30 23:23:09) Review request for Flume. Summary ------- I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature. This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4577/diff Testing ------- Tested invocation using both "node" and "agent". Thanks, Mike
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-03-31 02:33:49, Arvind Prabhakar wrote:

      > +1

      Mike - can you please attach this patch to the Jira.

      • Arvind

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4577/#review6599
      -----------------------------------------------------------

      On 2012-03-30 23:23:09, Mike Percy wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4577/

      -----------------------------------------------------------

      (Updated 2012-03-30 23:23:09)

      Review request for Flume.

      Summary

      -------

      I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.

      This addresses bug FLUME-999.

      https://issues.apache.org/jira/browse/FLUME-999

      Diffs

      -----

      bin/flume-ng a31f171

      Diff: https://reviews.apache.org/r/4577/diff

      Testing

      -------

      Tested invocation using both "node" and "agent".

      Thanks,

      Mike

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-03-31 02:33:49, Arvind Prabhakar wrote: > +1 Mike - can you please attach this patch to the Jira. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/#review6599 ----------------------------------------------------------- On 2012-03-30 23:23:09, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/ ----------------------------------------------------------- (Updated 2012-03-30 23:23:09) Review request for Flume. Summary ------- I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature. This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4577/diff Testing ------- Tested invocation using both "node" and "agent". Thanks, Mike
      Hide
      Mike Percy added a comment -

      Please assign attribution to Alexander Lorenz-Alten and Mike Percy

      Show
      Mike Percy added a comment - Please assign attribution to Alexander Lorenz-Alten and Mike Percy
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4577/
      -----------------------------------------------------------

      (Updated 2012-04-01 23:19:56.861859)

      Review request for Flume.

      Changes
      -------

      Rebasing patch after recent changes to flume-ng script.

      Summary
      -------

      I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.

      This addresses bug FLUME-999.
      https://issues.apache.org/jira/browse/FLUME-999

      Diffs (updated)


      bin/flume-ng acde274

      Diff: https://reviews.apache.org/r/4577/diff

      Testing
      -------

      Tested invocation using both "node" and "agent".

      Thanks,

      Mike

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/ ----------------------------------------------------------- (Updated 2012-04-01 23:19:56.861859) Review request for Flume. Changes ------- Rebasing patch after recent changes to flume-ng script. Summary ------- I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature. This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs (updated) bin/flume-ng acde274 Diff: https://reviews.apache.org/r/4577/diff Testing ------- Tested invocation using both "node" and "agent". Thanks, Mike
      Hide
      Mike Percy added a comment -

      Rebased patch.

      Show
      Mike Percy added a comment - Rebased patch.
      Hide
      Arvind Prabhakar added a comment -

      Patch committed. Thanks Alex and Mike!

      Show
      Arvind Prabhakar added a comment - Patch committed. Thanks Alex and Mike!
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4577/#review6614
      -----------------------------------------------------------

      Ship it!

      • Arvind

      On 2012-04-01 23:19:56, Mike Percy wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4577/

      -----------------------------------------------------------

      (Updated 2012-04-01 23:19:56)

      Review request for Flume.

      Summary

      -------

      I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature.

      This addresses bug FLUME-999.

      https://issues.apache.org/jira/browse/FLUME-999

      Diffs

      -----

      bin/flume-ng acde274

      Diff: https://reviews.apache.org/r/4577/diff

      Testing

      -------

      Tested invocation using both "node" and "agent".

      Thanks,

      Mike

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/#review6614 ----------------------------------------------------------- Ship it! Arvind On 2012-04-01 23:19:56, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4577/ ----------------------------------------------------------- (Updated 2012-04-01 23:19:56) Review request for Flume. Summary ------- I spoke to Alex and he said he's alright with me picking this up. This patch simply replaces node with agent in the flume script. The node is retained as a deprecated back-compat feature. This addresses bug FLUME-999 . https://issues.apache.org/jira/browse/FLUME-999 Diffs ----- bin/flume-ng acde274 Diff: https://reviews.apache.org/r/4577/diff Testing ------- Tested invocation using both "node" and "agent". Thanks, Mike
      Hide
      Hudson added a comment -

      Integrated in flume-trunk #155 (See https://builds.apache.org/job/flume-trunk/155/)
      FLUME-999. Update init scripts and variables to fit the term agent.

      (Alexander Lorenz-Alten, Mike Percy via Arvind Prabhakar) (Revision 1308222)

      Result = SUCCESS
      arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308222
      Files :

      • /incubator/flume/trunk/bin/flume-ng
      Show
      Hudson added a comment - Integrated in flume-trunk #155 (See https://builds.apache.org/job/flume-trunk/155/ ) FLUME-999 . Update init scripts and variables to fit the term agent. (Alexander Lorenz-Alten, Mike Percy via Arvind Prabhakar) (Revision 1308222) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308222 Files : /incubator/flume/trunk/bin/flume-ng

        People

        • Assignee:
          Mike Percy
          Reporter:
          Alexander Alten-Lorenz
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development