Flume
  1. Flume
  2. FLUME-969

Need a library that would allow external tools to parse and validate flume properties file configuration

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: v1.0.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently the configuration provider implementation encompasses all the syntactic and structural validation rules for loading the configuration. Externalizing this functionality to a library will allow external tools to easily operate on flume configuration files and be able to help parse and validate these files.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4010/
        -----------------------------------------------------------

        (Updated 2012-02-23 09:07:12.776308)

        Review request for Flume.

        Changes
        -------

        All changes

        Summary
        -------

        This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea.

        This addresses bug FLUME-969.
        https://issues.apache.org/jira/browse/FLUME-969

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-node/pom.xml b9b062e
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
        pom.xml d785762

        Diff: https://reviews.apache.org/r/4010/diff

        Testing
        -------

        I will add tests once I get initial feedback.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4010/ ----------------------------------------------------------- (Updated 2012-02-23 09:07:12.776308) Review request for Flume. Changes ------- All changes Summary ------- This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea. This addresses bug FLUME-969 . https://issues.apache.org/jira/browse/FLUME-969 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-node/pom.xml b9b062e flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1 pom.xml d785762 Diff: https://reviews.apache.org/r/4010/diff Testing ------- I will add tests once I get initial feedback. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4010/
        -----------------------------------------------------------

        (Updated 2012-02-23 08:53:47.389553)

        Review request for Flume.

        Changes
        -------

        Missed the new files which were added.

        Summary
        -------

        This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea.

        This addresses bug FLUME-969.
        https://issues.apache.org/jira/browse/FLUME-969

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        Diff: https://reviews.apache.org/r/4010/diff

        Testing
        -------

        I will add tests once I get initial feedback.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4010/ ----------------------------------------------------------- (Updated 2012-02-23 08:53:47.389553) Review request for Flume. Changes ------- Missed the new files which were added. Summary ------- This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea. This addresses bug FLUME-969 . https://issues.apache.org/jira/browse/FLUME-969 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION Diff: https://reviews.apache.org/r/4010/diff Testing ------- I will add tests once I get initial feedback. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4010/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea.

        This addresses bug FLUME-969.
        https://issues.apache.org/jira/browse/FLUME-969

        Diffs


        flume-ng-node/pom.xml b9b062e
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1
        pom.xml d785762

        Diff: https://reviews.apache.org/r/4010/diff

        Testing
        -------

        I will add tests once I get initial feedback.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4010/ ----------------------------------------------------------- Review request for Flume. Summary ------- This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea. This addresses bug FLUME-969 . https://issues.apache.org/jira/browse/FLUME-969 Diffs flume-ng-node/pom.xml b9b062e flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1 pom.xml d785762 Diff: https://reviews.apache.org/r/4010/diff Testing ------- I will add tests once I get initial feedback. Thanks, Hari
        Hide
        Arvind Prabhakar added a comment -

        Duplicate of FLUME-968.

        Show
        Arvind Prabhakar added a comment - Duplicate of FLUME-968 .
        Hide
        Brock Noland added a comment -

        Looks like a dup of FLUME-968

        Show
        Brock Noland added a comment - Looks like a dup of FLUME-968

          People

          • Assignee:
            Unassigned
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development