Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.0.0
    • Fix Version/s: v1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      This includes the FanoutChannel as well as JsonFileConfigurationProvider. Since we have these in the history of source control, we can revive them at anytime as needed rather than incrementally maintaining and not use them going forward.

      1. FLUME-940-1-svn.diff
        23 kB
        Arvind Prabhakar

        Issue Links

          Activity

          Arvind Prabhakar created issue -
          Arvind Prabhakar made changes -
          Field Original Value New Value
          Assignee Arvind Prabhakar [ aprabhakar ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3698/
          -----------------------------------------------------------

          Review request for Flume and Prasad Mujumdar.

          Summary
          -------

          Removed the FanoutChannel and JsonFileConfigurationProvider implementation.

          This addresses bug FLUME-940.
          https://issues.apache.org/jira/browse/FLUME-940

          Diffs


          flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java b9ce7a5
          flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java ca21794
          flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java ada9a72
          flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java f48e681
          flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java ce4e752
          flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 2b1599d

          Diff: https://reviews.apache.org/r/3698/diff

          Testing
          -------

          Ran all unit tests.

          Thanks,

          Arvind

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3698/ ----------------------------------------------------------- Review request for Flume and Prasad Mujumdar. Summary ------- Removed the FanoutChannel and JsonFileConfigurationProvider implementation. This addresses bug FLUME-940 . https://issues.apache.org/jira/browse/FLUME-940 Diffs flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java b9ce7a5 flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java ca21794 flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java ada9a72 flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java f48e681 flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java ce4e752 flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 2b1599d Diff: https://reviews.apache.org/r/3698/diff Testing ------- Ran all unit tests. Thanks, Arvind
          Arvind Prabhakar made changes -
          Attachment FLUME-940-1-svn.diff [ 12512487 ]
          Arvind Prabhakar made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s v1.0.0 [ 12318896 ]
          Fix Version/s v1.1.0 [ 12319284 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3698/#review4743
          -----------------------------------------------------------

          Ship it!

          lgtm

          • Prasad

          On 2012-01-30 22:37:38, Arvind Prabhakar wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3698/

          -----------------------------------------------------------

          (Updated 2012-01-30 22:37:38)

          Review request for Flume and Prasad Mujumdar.

          Summary

          -------

          Removed the FanoutChannel and JsonFileConfigurationProvider implementation.

          This addresses bug FLUME-940.

          https://issues.apache.org/jira/browse/FLUME-940

          Diffs

          -----

          flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java b9ce7a5

          flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java ca21794

          flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java ada9a72

          flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java f48e681

          flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java ce4e752

          flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 2b1599d

          Diff: https://reviews.apache.org/r/3698/diff

          Testing

          -------

          Ran all unit tests.

          Thanks,

          Arvind

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3698/#review4743 ----------------------------------------------------------- Ship it! lgtm Prasad On 2012-01-30 22:37:38, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3698/ ----------------------------------------------------------- (Updated 2012-01-30 22:37:38) Review request for Flume and Prasad Mujumdar. Summary ------- Removed the FanoutChannel and JsonFileConfigurationProvider implementation. This addresses bug FLUME-940 . https://issues.apache.org/jira/browse/FLUME-940 Diffs ----- flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java b9ce7a5 flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java ca21794 flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java ada9a72 flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java f48e681 flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java ce4e752 flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 2b1599d Diff: https://reviews.apache.org/r/3698/diff Testing ------- Ran all unit tests. Thanks, Arvind
          Hide
          Arvind Prabhakar added a comment -

          Patch committed.

          Show
          Arvind Prabhakar added a comment - Patch committed.
          Arvind Prabhakar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in flume-728 #102 (See https://builds.apache.org/job/flume-728/102/)
          FLUME-940. Removing unused code from Flume.

          arvind : http://svn.apache.org/viewvc/?view=rev&rev=1239218
          Files :

          • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java
          • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
          • /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java
          • /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java
          • /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java
          • /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
          Show
          Hudson added a comment - Integrated in flume-728 #102 (See https://builds.apache.org/job/flume-728/102/ ) FLUME-940 . Removing unused code from Flume. arvind : http://svn.apache.org/viewvc/?view=rev&rev=1239218 Files : /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
          Mike Percy made changes -
          Link This issue relates to FLUME-957 [ FLUME-957 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          45m 58s 1 Arvind Prabhakar 30/Jan/12 22:40
          Patch Available Patch Available Resolved Resolved
          1d 18h 47m 1 Arvind Prabhakar 01/Feb/12 17:27

            People

            • Assignee:
              Arvind Prabhakar
              Reporter:
              Arvind Prabhakar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development