Flume
  1. Flume
  2. FLUME-933

Default[Source|Sink|Channel]Factory implementation should do reference counting for create/unregistering instances.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      The current implementation of DefaultSourceFactory, DefaultSinkFactory and DefaultChannelFactory ensures that if a create() is called for the same name and type of object, it returns the previously created instance where available. However, on deregister it directly removes the created object from cache. This can lead to multiple instances of same name to exist within the VM which in turn can cause other problems.

      Instead if the factory implementation does reference counting, it will be able to ensure that the purge of an object happens only when the number of unregister calls matches the create calls.

        Activity

        Hide
        Arvind Prabhakar added a comment -

        Patch committed.

        Show
        Arvind Prabhakar added a comment - Patch committed.

          People

          • Assignee:
            Unassigned
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development