Flume
  1. Flume
  2. FLUME-925

Update build infrastructure to follow Apache Maven guidelines

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.0.0
    • Fix Version/s: v1.1.0
    • Component/s: None
    • Labels:
      None
    1. FLUME-925.patch
      8 kB
      Arvind Prabhakar
    2. FLUME-925-2.patch
      8 kB
      Arvind Prabhakar

      Activity

      Hide
      Hudson added a comment -

      Integrated in flume-728 #93 (See https://builds.apache.org/job/flume-728/93/)
      FLUME-925. Fixing build infrastructure to follow ASF guidelines.

      arvind : http://svn.apache.org/viewvc/?view=rev&rev=1229788
      Files :

      • /incubator/flume/branches/flume-728/flume-ng-channels/flume-file-channel/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-channels/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-core/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-dist/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-node/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/pom.xml
      • /incubator/flume/branches/flume-728/flume-ng-sinks/pom.xml
      • /incubator/flume/branches/flume-728/pom.xml
      Show
      Hudson added a comment - Integrated in flume-728 #93 (See https://builds.apache.org/job/flume-728/93/ ) FLUME-925 . Fixing build infrastructure to follow ASF guidelines. arvind : http://svn.apache.org/viewvc/?view=rev&rev=1229788 Files : /incubator/flume/branches/flume-728/flume-ng-channels/flume-file-channel/pom.xml /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/pom.xml /incubator/flume/branches/flume-728/flume-ng-channels/pom.xml /incubator/flume/branches/flume-728/flume-ng-core/pom.xml /incubator/flume/branches/flume-728/flume-ng-dist/pom.xml /incubator/flume/branches/flume-728/flume-ng-node/pom.xml /incubator/flume/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/pom.xml /incubator/flume/branches/flume-728/flume-ng-sinks/pom.xml /incubator/flume/branches/flume-728/pom.xml
      Hide
      Arvind Prabhakar added a comment -

      Patch committed.

      Show
      Arvind Prabhakar added a comment - Patch committed.
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3447/#review4305
      -----------------------------------------------------------

      Ship it!

      • Ralph

      On 2012-01-10 21:56:10, Arvind Prabhakar wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3447/

      -----------------------------------------------------------

      (Updated 2012-01-10 21:56:10)

      Review request for Flume and Prasad Mujumdar.

      Summary

      -------

      Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT

      This addresses bug FLUME-925.

      https://issues.apache.org/jira/browse/FLUME-925

      Diffs

      -----

      flume-ng-dist/pom.xml 44fe4f9

      flume-ng-node/pom.xml dae20f7

      flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9

      flume-ng-sinks/pom.xml ea04e7d

      pom.xml 7ea3c98

      flume-ng-channels/flume-file-channel/pom.xml cbf30ca

      flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9

      flume-ng-channels/pom.xml 84e0020

      flume-ng-core/pom.xml a2c4173

      Diff: https://reviews.apache.org/r/3447/diff

      Testing

      -------

      Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume).

      Thanks,

      Arvind

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/#review4305 ----------------------------------------------------------- Ship it! Ralph On 2012-01-10 21:56:10, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/ ----------------------------------------------------------- (Updated 2012-01-10 21:56:10) Review request for Flume and Prasad Mujumdar. Summary ------- Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT This addresses bug FLUME-925 . https://issues.apache.org/jira/browse/FLUME-925 Diffs ----- flume-ng-dist/pom.xml 44fe4f9 flume-ng-node/pom.xml dae20f7 flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 flume-ng-sinks/pom.xml ea04e7d pom.xml 7ea3c98 flume-ng-channels/flume-file-channel/pom.xml cbf30ca flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 flume-ng-channels/pom.xml 84e0020 flume-ng-core/pom.xml a2c4173 Diff: https://reviews.apache.org/r/3447/diff Testing ------- Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume). Thanks, Arvind
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3447/
      -----------------------------------------------------------

      (Updated 2012-01-10 21:56:10.324647)

      Review request for Flume and Prasad Mujumdar.

      Changes
      -------

      Updated the poms to use dependency management for inter-module dependency version specification.

      Summary
      -------

      Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT

      This addresses bug FLUME-925.
      https://issues.apache.org/jira/browse/FLUME-925

      Diffs (updated)


      flume-ng-dist/pom.xml 44fe4f9
      flume-ng-node/pom.xml dae20f7
      flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9
      flume-ng-sinks/pom.xml ea04e7d
      pom.xml 7ea3c98
      flume-ng-channels/flume-file-channel/pom.xml cbf30ca
      flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9
      flume-ng-channels/pom.xml 84e0020
      flume-ng-core/pom.xml a2c4173

      Diff: https://reviews.apache.org/r/3447/diff

      Testing
      -------

      Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume).

      Thanks,

      Arvind

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/ ----------------------------------------------------------- (Updated 2012-01-10 21:56:10.324647) Review request for Flume and Prasad Mujumdar. Changes ------- Updated the poms to use dependency management for inter-module dependency version specification. Summary ------- Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT This addresses bug FLUME-925 . https://issues.apache.org/jira/browse/FLUME-925 Diffs (updated) flume-ng-dist/pom.xml 44fe4f9 flume-ng-node/pom.xml dae20f7 flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 flume-ng-sinks/pom.xml ea04e7d pom.xml 7ea3c98 flume-ng-channels/flume-file-channel/pom.xml cbf30ca flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 flume-ng-channels/pom.xml 84e0020 flume-ng-core/pom.xml a2c4173 Diff: https://reviews.apache.org/r/3447/diff Testing ------- Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume). Thanks, Arvind
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-01-10 19:57:11, Ralph Goers wrote:

      > Many of the child poms reference other project artifacts and specify the Flume version. It is a better practice to declare a variable in the parent pom that declares the Flume version. Then add a dependencyManagement section to the parent pom that defines all the Flume artifacts with their version. Finally, remove the version in each of the subproject so they will pick up the version from the managed dependency.

      Thanks for the review Ralph. I agree with your suggestion and will udpate poms accordingly.

      • Arvind

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3447/#review4302
      -----------------------------------------------------------

      On 2012-01-10 19:16:02, Arvind Prabhakar wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3447/

      -----------------------------------------------------------

      (Updated 2012-01-10 19:16:02)

      Review request for Flume and Prasad Mujumdar.

      Summary

      -------

      Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT

      This addresses bug FLUME-925.

      https://issues.apache.org/jira/browse/FLUME-925

      Diffs

      -----

      flume-ng-channels/flume-file-channel/pom.xml cbf30ca

      flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9

      flume-ng-channels/pom.xml 84e0020

      flume-ng-core/pom.xml a2c4173

      flume-ng-dist/pom.xml 44fe4f9

      flume-ng-node/pom.xml dae20f7

      flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9

      flume-ng-sinks/pom.xml ea04e7d

      pom.xml 7ea3c98

      Diff: https://reviews.apache.org/r/3447/diff

      Testing

      -------

      Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume).

      Thanks,

      Arvind

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-01-10 19:57:11, Ralph Goers wrote: > Many of the child poms reference other project artifacts and specify the Flume version. It is a better practice to declare a variable in the parent pom that declares the Flume version. Then add a dependencyManagement section to the parent pom that defines all the Flume artifacts with their version. Finally, remove the version in each of the subproject so they will pick up the version from the managed dependency. Thanks for the review Ralph. I agree with your suggestion and will udpate poms accordingly. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/#review4302 ----------------------------------------------------------- On 2012-01-10 19:16:02, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/ ----------------------------------------------------------- (Updated 2012-01-10 19:16:02) Review request for Flume and Prasad Mujumdar. Summary ------- Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT This addresses bug FLUME-925 . https://issues.apache.org/jira/browse/FLUME-925 Diffs ----- flume-ng-channels/flume-file-channel/pom.xml cbf30ca flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 flume-ng-channels/pom.xml 84e0020 flume-ng-core/pom.xml a2c4173 flume-ng-dist/pom.xml 44fe4f9 flume-ng-node/pom.xml dae20f7 flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 flume-ng-sinks/pom.xml ea04e7d pom.xml 7ea3c98 Diff: https://reviews.apache.org/r/3447/diff Testing ------- Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume). Thanks, Arvind
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3447/#review4302
      -----------------------------------------------------------

      Many of the child poms reference other project artifacts and specify the Flume version. It is a better practice to declare a variable in the parent pom that declares the Flume version. Then add a dependencyManagement section to the parent pom that defines all the Flume artifacts with their version. Finally, remove the version in each of the subproject so they will pick up the version from the managed dependency.

      • Ralph

      On 2012-01-10 19:16:02, Arvind Prabhakar wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3447/

      -----------------------------------------------------------

      (Updated 2012-01-10 19:16:02)

      Review request for Flume and Prasad Mujumdar.

      Summary

      -------

      Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT

      This addresses bug FLUME-925.

      https://issues.apache.org/jira/browse/FLUME-925

      Diffs

      -----

      flume-ng-channels/flume-file-channel/pom.xml cbf30ca

      flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9

      flume-ng-channels/pom.xml 84e0020

      flume-ng-core/pom.xml a2c4173

      flume-ng-dist/pom.xml 44fe4f9

      flume-ng-node/pom.xml dae20f7

      flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9

      flume-ng-sinks/pom.xml ea04e7d

      pom.xml 7ea3c98

      Diff: https://reviews.apache.org/r/3447/diff

      Testing

      -------

      Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume).

      Thanks,

      Arvind

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/#review4302 ----------------------------------------------------------- Many of the child poms reference other project artifacts and specify the Flume version. It is a better practice to declare a variable in the parent pom that declares the Flume version. Then add a dependencyManagement section to the parent pom that defines all the Flume artifacts with their version. Finally, remove the version in each of the subproject so they will pick up the version from the managed dependency. Ralph On 2012-01-10 19:16:02, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/ ----------------------------------------------------------- (Updated 2012-01-10 19:16:02) Review request for Flume and Prasad Mujumdar. Summary ------- Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT This addresses bug FLUME-925 . https://issues.apache.org/jira/browse/FLUME-925 Diffs ----- flume-ng-channels/flume-file-channel/pom.xml cbf30ca flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 flume-ng-channels/pom.xml 84e0020 flume-ng-core/pom.xml a2c4173 flume-ng-dist/pom.xml 44fe4f9 flume-ng-node/pom.xml dae20f7 flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 flume-ng-sinks/pom.xml ea04e7d pom.xml 7ea3c98 Diff: https://reviews.apache.org/r/3447/diff Testing ------- Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume). Thanks, Arvind
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3447/
      -----------------------------------------------------------

      Review request for Flume and Prasad Mujumdar.

      Summary
      -------

      Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT

      This addresses bug FLUME-925.
      https://issues.apache.org/jira/browse/FLUME-925

      Diffs


      flume-ng-channels/flume-file-channel/pom.xml cbf30ca
      flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9
      flume-ng-channels/pom.xml 84e0020
      flume-ng-core/pom.xml a2c4173
      flume-ng-dist/pom.xml 44fe4f9
      flume-ng-node/pom.xml dae20f7
      flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9
      flume-ng-sinks/pom.xml ea04e7d
      pom.xml 7ea3c98

      Diff: https://reviews.apache.org/r/3447/diff

      Testing
      -------

      Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume).

      Thanks,

      Arvind

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/ ----------------------------------------------------------- Review request for Flume and Prasad Mujumdar. Summary ------- Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT This addresses bug FLUME-925 . https://issues.apache.org/jira/browse/FLUME-925 Diffs flume-ng-channels/flume-file-channel/pom.xml cbf30ca flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 flume-ng-channels/pom.xml 84e0020 flume-ng-core/pom.xml a2c4173 flume-ng-dist/pom.xml 44fe4f9 flume-ng-node/pom.xml dae20f7 flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 flume-ng-sinks/pom.xml ea04e7d pom.xml 7ea3c98 Diff: https://reviews.apache.org/r/3447/diff Testing ------- Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume). Thanks, Arvind

        People

        • Assignee:
          Arvind Prabhakar
          Reporter:
          Arvind Prabhakar
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development