[FLUME-883] Flume E2E sink could send incorrect ACKs if there are HDFS file close errors

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.4
• Fix Version/s: 0.9.5
• Component/s: Sinks+Sources
• Assignee: Prasad Suresh Mujumdar
• Reporter: Prasad Suresh Mujumdar
• Created: 15/Dec/11 18:59
• Updated: 16/Dec/11 01:35
• Resolved: 16/Dec/11 01:35

Description

The E2E collector sink saves the batch tags as the batches are passed to the downstream sinks. The ACKs are flushed when the roller close the file. Currently for the HDFS sink, the close is the only operation that guarantees that data is safely stored. Hence the acks are sent on close. If for some reason, the writes fail then we don't send the acks assuming the data is lost. The E2E mechanism then resends the data.
The problem is that if the close fails then we don't clear the accumulated acks for that current rolltag. Hence its possible that the next successful roll could send those acks and hence the batch will not be resent.