Flume
  1. Flume
  2. FLUME-825

Need to remove dependency on hadoop core from flume-ng-core project

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: NG alpha 1
    • Fix Version/s: NG alpha 2
    • Component/s: Build
    • Labels:
      None

      Description

      flume-ng-core's pom.xml file says:
      FIXME: There should be no dependency on Hadoop in Flume core.

      Please remove the dependency. Thanks.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        9h 25m 1 E. Sammer 01/Nov/11 08:16
        Patch Available Patch Available Resolved Resolved
        10h 48m 1 E. Sammer 01/Nov/11 19:05
        Resolved Resolved Closed Closed
        8s 1 E. Sammer 01/Nov/11 19:05
        Hide
        Hudson added a comment -

        Integrated in flume-728 #59 (See https://builds.apache.org/job/flume-728/59/)
        FLUME-825: Need to remove dependency on hadoop core from flume-ng-core project

        esammer : http://svn.apache.org/viewvc/?view=rev&rev=1196214
        Files :

        • /incubator/flume/branches/flume-728/flume-ng-core/pom.xml
        • /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
        Show
        Hudson added a comment - Integrated in flume-728 #59 (See https://builds.apache.org/job/flume-728/59/ ) FLUME-825 : Need to remove dependency on hadoop core from flume-ng-core project esammer : http://svn.apache.org/viewvc/?view=rev&rev=1196214 Files : /incubator/flume/branches/flume-728/flume-ng-core/pom.xml /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
        E. Sammer made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        E. Sammer made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hide
        E. Sammer added a comment -

        Pushed to branch flume-728.

        Show
        E. Sammer added a comment - Pushed to branch flume-728.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2660/#review2992
        -----------------------------------------------------------

        Ship it!

        • Prasad

        On 2011-11-01 08:15:52, Eric Sammer wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2660/

        -----------------------------------------------------------

        (Updated 2011-11-01 08:15:52)

        Review request for Flume and Prasad Mujumdar.

        Summary

        -------

        * Remove Hadoop as a flume-ng-core dep.

        * Added commons-cli as an explicit dep. We were accidentally getting it via hadoop.

        * Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test.

        This addresses bug FLUME-825.

        https://issues.apache.org/jira/browse/FLUME-825

        Diffs

        -----

        i/flume-ng-core/pom.xml 90dbcaa

        i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1

        Diff: https://reviews.apache.org/r/2660/diff

        Testing

        -------

        Unit tests pass.

        Thanks,

        Eric

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2660/#review2992 ----------------------------------------------------------- Ship it! Prasad On 2011-11-01 08:15:52, Eric Sammer wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2660/ ----------------------------------------------------------- (Updated 2011-11-01 08:15:52) Review request for Flume and Prasad Mujumdar. Summary ------- * Remove Hadoop as a flume-ng-core dep. * Added commons-cli as an explicit dep. We were accidentally getting it via hadoop. * Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test. This addresses bug FLUME-825 . https://issues.apache.org/jira/browse/FLUME-825 Diffs ----- i/flume-ng-core/pom.xml 90dbcaa i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1 Diff: https://reviews.apache.org/r/2660/diff Testing ------- Unit tests pass. Thanks, Eric
        E. Sammer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee E. Sammer [ esammer ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2660/
        -----------------------------------------------------------

        Review request for Flume and Prasad Mujumdar.

        Summary
        -------

        • Remove Hadoop as a flume-ng-core dep.
        • Added commons-cli as an explicit dep. We were accidentally getting it via hadoop.
        • Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test.

        This addresses bug FLUME-825.
        https://issues.apache.org/jira/browse/FLUME-825

        Diffs


        i/flume-ng-core/pom.xml 90dbcaa
        i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1

        Diff: https://reviews.apache.org/r/2660/diff

        Testing
        -------

        Unit tests pass.

        Thanks,

        Eric

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2660/ ----------------------------------------------------------- Review request for Flume and Prasad Mujumdar. Summary ------- Remove Hadoop as a flume-ng-core dep. Added commons-cli as an explicit dep. We were accidentally getting it via hadoop. Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test. This addresses bug FLUME-825 . https://issues.apache.org/jira/browse/FLUME-825 Diffs i/flume-ng-core/pom.xml 90dbcaa i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1 Diff: https://reviews.apache.org/r/2660/diff Testing ------- Unit tests pass. Thanks, Eric
        Hide
        E. Sammer added a comment -
        Show
        E. Sammer added a comment - Reivew up: https://reviews.apache.org/r/2660/
        E. Sammer made changes -
        Field Original Value New Value
        Fix Version/s NG alpha 2 [ 12318651 ]
        Hide
        E. Sammer added a comment -

        Targeting for NG alpha 2.

        Pretty sure this is safe now that Prasad moved the HDFS sink into a separate module. Let's try and get him to chime in on this.

        Show
        E. Sammer added a comment - Targeting for NG alpha 2. Pretty sure this is safe now that Prasad moved the HDFS sink into a separate module. Let's try and get him to chime in on this.
        Will McQueen created issue -

          People

          • Assignee:
            E. Sammer
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development