Flume
  1. Flume
  2. FLUME-825

Need to remove dependency on hadoop core from flume-ng-core project

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: NG alpha 1
    • Fix Version/s: NG alpha 2
    • Component/s: Build
    • Labels:
      None

      Description

      flume-ng-core's pom.xml file says:
      FIXME: There should be no dependency on Hadoop in Flume core.

      Please remove the dependency. Thanks.

        Activity

        Hide
        Hudson added a comment -

        Integrated in flume-728 #59 (See https://builds.apache.org/job/flume-728/59/)
        FLUME-825: Need to remove dependency on hadoop core from flume-ng-core project

        esammer : http://svn.apache.org/viewvc/?view=rev&rev=1196214
        Files :

        • /incubator/flume/branches/flume-728/flume-ng-core/pom.xml
        • /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
        Show
        Hudson added a comment - Integrated in flume-728 #59 (See https://builds.apache.org/job/flume-728/59/ ) FLUME-825 : Need to remove dependency on hadoop core from flume-ng-core project esammer : http://svn.apache.org/viewvc/?view=rev&rev=1196214 Files : /incubator/flume/branches/flume-728/flume-ng-core/pom.xml /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
        Hide
        E. Sammer added a comment -

        Pushed to branch flume-728.

        Show
        E. Sammer added a comment - Pushed to branch flume-728.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2660/#review2992
        -----------------------------------------------------------

        Ship it!

        • Prasad

        On 2011-11-01 08:15:52, Eric Sammer wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2660/

        -----------------------------------------------------------

        (Updated 2011-11-01 08:15:52)

        Review request for Flume and Prasad Mujumdar.

        Summary

        -------

        * Remove Hadoop as a flume-ng-core dep.

        * Added commons-cli as an explicit dep. We were accidentally getting it via hadoop.

        * Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test.

        This addresses bug FLUME-825.

        https://issues.apache.org/jira/browse/FLUME-825

        Diffs

        -----

        i/flume-ng-core/pom.xml 90dbcaa

        i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1

        Diff: https://reviews.apache.org/r/2660/diff

        Testing

        -------

        Unit tests pass.

        Thanks,

        Eric

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2660/#review2992 ----------------------------------------------------------- Ship it! Prasad On 2011-11-01 08:15:52, Eric Sammer wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2660/ ----------------------------------------------------------- (Updated 2011-11-01 08:15:52) Review request for Flume and Prasad Mujumdar. Summary ------- * Remove Hadoop as a flume-ng-core dep. * Added commons-cli as an explicit dep. We were accidentally getting it via hadoop. * Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test. This addresses bug FLUME-825 . https://issues.apache.org/jira/browse/FLUME-825 Diffs ----- i/flume-ng-core/pom.xml 90dbcaa i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1 Diff: https://reviews.apache.org/r/2660/diff Testing ------- Unit tests pass. Thanks, Eric
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2660/
        -----------------------------------------------------------

        Review request for Flume and Prasad Mujumdar.

        Summary
        -------

        • Remove Hadoop as a flume-ng-core dep.
        • Added commons-cli as an explicit dep. We were accidentally getting it via hadoop.
        • Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test.

        This addresses bug FLUME-825.
        https://issues.apache.org/jira/browse/FLUME-825

        Diffs


        i/flume-ng-core/pom.xml 90dbcaa
        i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1

        Diff: https://reviews.apache.org/r/2660/diff

        Testing
        -------

        Unit tests pass.

        Thanks,

        Eric

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2660/ ----------------------------------------------------------- Review request for Flume and Prasad Mujumdar. Summary ------- Remove Hadoop as a flume-ng-core dep. Added commons-cli as an explicit dep. We were accidentally getting it via hadoop. Cleaned up unused org.apache.hadoop.* class usage in the ExecSource test. This addresses bug FLUME-825 . https://issues.apache.org/jira/browse/FLUME-825 Diffs i/flume-ng-core/pom.xml 90dbcaa i/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6607bc1 Diff: https://reviews.apache.org/r/2660/diff Testing ------- Unit tests pass. Thanks, Eric
        Hide
        E. Sammer added a comment -
        Show
        E. Sammer added a comment - Reivew up: https://reviews.apache.org/r/2660/
        Hide
        E. Sammer added a comment -

        Targeting for NG alpha 2.

        Pretty sure this is safe now that Prasad moved the HDFS sink into a separate module. Let's try and get him to chime in on this.

        Show
        E. Sammer added a comment - Targeting for NG alpha 2. Pretty sure this is safe now that Prasad moved the HDFS sink into a separate module. Let's try and get him to chime in on this.

          People

          • Assignee:
            E. Sammer
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development