Flume
  1. Flume
  2. FLUME-802

Complete PropertyFileConfigurationProvider implementation

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: NG alpha 1
    • Fix Version/s: NG alpha 1
    • Component/s: None
    • Labels:
      None

      Description

      The property file based configuration provider PropertiesFileConfigurationProvider is not fully complete. It parses and loads a configuration but never exposes the configuration to Flume.

        Activity

        Hide
        E. Sammer added a comment -

        Committed to the flume-728 branch.

        Show
        E. Sammer added a comment - Committed to the flume-728 branch.
        Hide
        Hudson added a comment -

        Integrated in flume-728 #45 (See https://builds.apache.org/job/flume-728/45/)
        FLUME-802: Complete PropertyFileConfigurationProvider implementation

        • The skeletal flume node now uses the property file based configuration provider.
        • All Configurables now expect Strings and do proper parsing where necessary. This
          is because one does not yet rich types from java properties files, at least not
          the way we're using them.
        • Reformatted a bunch of things to soothe my OCD (sorry Arvind).
        • Added a bunch of accessors to get at some of the internals of FlumeConfiguration.
          We probably need to rename / clean a bunch of this stuff.

        esammer : http://svn.apache.org/viewvc/?view=rev&rev=1186585
        Files :

        • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java
        • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
        • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java
        • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
        • /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/Application.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
        Show
        Hudson added a comment - Integrated in flume-728 #45 (See https://builds.apache.org/job/flume-728/45/ ) FLUME-802 : Complete PropertyFileConfigurationProvider implementation The skeletal flume node now uses the property file based configuration provider. All Configurables now expect Strings and do proper parsing where necessary. This is because one does not yet rich types from java properties files, at least not the way we're using them. Reformatted a bunch of things to soothe my OCD (sorry Arvind). Added a bunch of accessors to get at some of the internals of FlumeConfiguration. We probably need to rename / clean a bunch of this stuff. esammer : http://svn.apache.org/viewvc/?view=rev&rev=1186585 Files : /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java /incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java /incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/Application.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
        Hide
        Hudson added a comment -

        Integrated in flume-728 #46 (See https://builds.apache.org/job/flume-728/46/)
        FLUME-807: Fix tests broken by FLUME-802 changes

        • Minor reformatting occurred.
        • Updated a test to not reference any JUnit 3 APIs.

        esammer : http://svn.apache.org/viewvc/?view=rev&rev=1186600
        Files :

        • /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
        • /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java
        • /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java
        • /incubator/flume/branches/flume-728/flume-ng-node/src/test/resources/flume-conf.json
        • /incubator/flume/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java
        Show
        Hudson added a comment - Integrated in flume-728 #46 (See https://builds.apache.org/job/flume-728/46/ ) FLUME-807 : Fix tests broken by FLUME-802 changes Minor reformatting occurred. Updated a test to not reference any JUnit 3 APIs. esammer : http://svn.apache.org/viewvc/?view=rev&rev=1186600 Files : /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java /incubator/flume/branches/flume-728/flume-ng-node/src/test/resources/flume-conf.json /incubator/flume/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java

          People

          • Assignee:
            E. Sammer
            Reporter:
            E. Sammer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development