Flume
  1. Flume
  2. FLUME-601

Fix Cobertura coverage testing dependencies.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v0.9.5
    • Component/s: Build
    • Labels:
      None
    • Release Note:
      This is was fixed for the ant build between the 0.9.3 and the 0.9.4 versions, and will not be part of an official release.

      Description

      Covertura is a code coverage tool, which was integrated into flume's ant script. Some changes to the build apparently broke this functionality and causes class not found exceptions during build/test with these options.

        Activity

        Hide
        Jonathan Hsieh added a comment -

        committed to ant branch.

        Show
        Jonathan Hsieh added a comment - committed to ant branch.
        Hide
        Jonathan Hsieh added a comment - - edited
        Show
        Jonathan Hsieh added a comment - - edited review here https://review.cloudera.org/r/1702/
        Hide
        Jonathan Hsieh added a comment -

        Jars specifically added for cobertura (ivy pull for cobertura does not pull dependencies. Adding this for future info with maven build.)

        asm-3.3.1.jar
        asm-analysis-3.3.1.jar
        asm-commons-3.3.1.jar
        asm-tree-3.3.1.jar
        asm-util-3.3.1.jar
        asm-xml-3.3.1.jar
        jakarta-oro-2.0.8.jar

        Show
        Jonathan Hsieh added a comment - Jars specifically added for cobertura (ivy pull for cobertura does not pull dependencies. Adding this for future info with maven build.) asm-3.3.1.jar asm-analysis-3.3.1.jar asm-commons-3.3.1.jar asm-tree-3.3.1.jar asm-util-3.3.1.jar asm-xml-3.3.1.jar jakarta-oro-2.0.8.jar
        Hide
        Jonathan Hsieh added a comment - - edited

        licensing terms from asm*.jar library are not apache, here's a link. http://asm.ow2.org/license.html

        This is 3 clause New BSD, and thus allowed.

        Show
        Jonathan Hsieh added a comment - - edited licensing terms from asm*.jar library are not apache, here's a link. http://asm.ow2.org/license.html This is 3 clause New BSD, and thus allowed.
        Hide
        Jonathan Hsieh added a comment -

        also, the incorrect cobertura jar name was included at test execution time.

        Show
        Jonathan Hsieh added a comment - also, the incorrect cobertura jar name was included at test execution time.
        Hide
        Jonathan Hsieh added a comment -

        Needs asm.jar library (java byte code rewriter lib) and Jakarta ORO (perl like regex?)

        Show
        Jonathan Hsieh added a comment - Needs asm.jar library (java byte code rewriter lib) and Jakarta ORO (perl like regex?)

          People

          • Assignee:
            Jonathan Hsieh
            Reporter:
            Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development