Flume
  1. Flume
  2. FLUME-576

Properly reset FlumeBuilder SourceFactory after testing

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: v0.9.3
    • Fix Version/s: v0.9.5
    • Component/s: Test
    • Labels:
      None

      Description

      In com.cloudera.flume.agent.TestFlumeNode#testRestartNextException():

      FlumeBuilder.setSourceFactory(new SourceFactory() {
        public EventSource getSource(Context ctx, String name, String... args) {
          return new NextExnSource();
        }
      }
      

      This pollutes the JVM for all future tests leading to spurious errors in that it returns NextExnSource for any source that gets constructed.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          354d 5h 36m 1 Alexander Alten-Lorenz 07/Mar/12 11:36
          Resolved Resolved Reopened Reopened
          7h 12m 1 Alexander Alten-Lorenz 07/Mar/12 18:48
          Reopened Reopened Resolved Resolved
          972d 15h 17m 1 Ashish Paliwal 05/Nov/14 10:06
          Ashish Paliwal made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          Hide
          Ashish Paliwal added a comment -

          Won't fix. 0.X branch not maintained anymore

          Show
          Ashish Paliwal added a comment - Won't fix. 0.X branch not maintained anymore
          Alexander Alten-Lorenz made changes -
          Resolution Won't Fix [ 2 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Alexander Alten-Lorenz made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          E. Sammer made changes -
          Assignee E. Sammer [ esammer ]
          Hide
          E. Sammer added a comment -

          Removing myself from this. Not going to have time to focus on it.

          Show
          E. Sammer added a comment - Removing myself from this. Not going to have time to focus on it.
          Mark Thomas made changes -
          Project Import Tue Aug 02 16:57:12 UTC 2011 [ 1312304232406 ]
          Jonathan Hsieh made changes -
          Link This issue relates to FLUME-575 [ FLUME-575 ]
          Jonathan Hsieh made changes -
          Fix Version/s v0.9.5 [ 10090 ]
          Fix Version/s v0.9.4 [ 10050 ]
          Hide
          Jonathan Hsieh added a comment -

          Better yet, FlumeBuilder should be made an object that is instantiated for each test. (removing any static state..)

          Show
          Jonathan Hsieh added a comment - Better yet, FlumeBuilder should be made an object that is instantiated for each test. (removing any static state..)
          E. Sammer made changes -
          Field Original Value New Value
          Description In com.cloudera.flume.agent.TestFlumeNode#testRestartNextException():

              FlumeBuilder.setSourceFactory(new SourceFactory() {
                public EventSource getSource(Context ctx, String name, String... args) {
                  return new NextExnSource();
                }

          This pollutes the JVM for all future tests leading to spurious errors in that it returns NextExnSource for *any* source that gets constructed.
          In com.cloudera.flume.agent.TestFlumeNode#testRestartNextException():

          {code}
          FlumeBuilder.setSourceFactory(new SourceFactory() {
            public EventSource getSource(Context ctx, String name, String... args) {
              return new NextExnSource();
            }
          }
          {code}

          This pollutes the JVM for all future tests leading to spurious errors in that it returns NextExnSource for *any* source that gets constructed.
          E. Sammer created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              E. Sammer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development