Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v0.9.5
    • Labels:
      None

      Description

      The current implementation of the hbase sink is built as part of flume. We would prefer having this as a plugin so that flume depend on hbase to compile or depend on an hbase jar at run time (which will happen when hbase sink is registered!)

        Issue Links

          Activity

          Arvind Prabhakar made changes -
          Fix Version/s v0.9.5 [ 12317558 ]
          Mark Thomas made changes -
          Assignee Disabled imported user [ flume_dani ] Dani Abel Rayan [ danirayan ]
          Mark Thomas made changes -
          Project Import Tue Aug 02 16:57:12 UTC 2011 [ 1312304232406 ]
          Hide
          Jonathan Hsieh added a comment - - edited

          committed to 'ant' and 'master' branches.

          Show
          Jonathan Hsieh added a comment - - edited committed to 'ant' and 'master' branches.
          Jonathan Hsieh made changes -
          Link This issue blocks FLUME-6 [ FLUME-6 ]
          Jonathan Hsieh made changes -
          Status Patch Available [ 10000 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Jonathan Hsieh added a comment -

          Updated hbase branch with changes.

          Show
          Jonathan Hsieh added a comment - Updated hbase branch with changes.
          Hide
          Jonathan Hsieh added a comment -

          Build works. Tests pass. Committed FLUME-354. Will put comments about FLUME-366 in that jira.

          Thanks Dani!

          Show
          Jonathan Hsieh added a comment - Build works. Tests pass. Committed FLUME-354 . Will put comments about FLUME-366 in that jira. Thanks Dani!
          flume_dani made changes -
          Attachment License Granted license to ASF [ licensed ]
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10362 ]
          Attachment 0005-FLUME-366-In-HBase-sink-make-parameter-writeBody-mor.patch [ 10363 ]
          Attachment License Granted license to ASF [ licensed ]
          Hide
          Dani Abel Rayan added a comment -

          Updated Patches

          Show
          Dani Abel Rayan added a comment - Updated Patches
          flume_dani made changes -
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10360 ]
          flume_dani made changes -
          Attachment 0005-FLUME-366-In-HBase-sink-make-parameter-writeBody-mor.patch [ 10361 ]
          flume_dani made changes -
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10358 ]
          flume_dani made changes -
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10354 ]
          flume_dani made changes -
          Attachment 0005-FLUME-366-In-HBase-sink-make-parameter-writeToBody-m.patch [ 10355 ]
          flume_dani made changes -
          Attachment 0005-FLUME-366-In-HBase-sink-make-the-parameter-writeBody.patch [ 10359 ]
          flume_dani made changes -
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10360 ]
          Attachment License Granted license to ASF [ licensed ]
          Attachment License Granted license to ASF [ licensed ]
          Attachment 0005-FLUME-366-In-HBase-sink-make-parameter-writeBody-mor.patch [ 10361 ]
          Hide
          Dani Abel Rayan added a comment -

          Took a new clone and updated Patches.
          354 goes first.

          Show
          Dani Abel Rayan added a comment - Took a new clone and updated Patches. 354 goes first.
          Hide
          Jonathan Hsieh added a comment -

          Dani,

          The xxx/SinkFactoryImpl.java part of the FLUME-366 patch should be in the FLUME-354. (just applying FLUME-366 breaks build) Could you update the patches again with this change?

          Thanks,
          Jon.

          Show
          Jonathan Hsieh added a comment - Dani, The xxx/SinkFactoryImpl.java part of the FLUME-366 patch should be in the FLUME-354 . (just applying FLUME-366 breaks build) Could you update the patches again with this change? Thanks, Jon.
          flume_dani made changes -
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10358 ]
          Attachment 0005-FLUME-366-In-HBase-sink-make-the-parameter-writeBody.patch [ 10359 ]
          Attachment License Granted license to ASF [ licensed ]
          Attachment License Granted license to ASF [ licensed ]
          Hide
          Dani Abel Rayan added a comment -

          Updated both the patches

          Show
          Dani Abel Rayan added a comment - Updated both the patches
          Hide
          Dani Abel Rayan added a comment -

          Jon,

          ../handlers/hbase does not have TestAttr2HBaseSink and TestHBaseSink files. Moreover, we need to write new set of Testcases once we decide the base-class

          Show
          Dani Abel Rayan added a comment - Jon, ../handlers/hbase does not have TestAttr2HBaseSink and TestHBaseSink files. Moreover, we need to write new set of Testcases once we decide the base-class
          Hide
          Jonathan Hsieh added a comment -

          Hi Dani,

          The series of FLUME-354, and FLUME-366 break test cases because the test cases aren't moved into the plugin dir. Specifically TestAttr2HBaseSink and TestHBaseSink test classes need to be moved into ./plugins/hbasesink/src/javatest/... Also, there should be a way to run the tests ('ant test') in the build.xml in ./plugins/hbasesink

          Jon.

          Show
          Jonathan Hsieh added a comment - Hi Dani, The series of FLUME-354 , and FLUME-366 break test cases because the test cases aren't moved into the plugin dir. Specifically TestAttr2HBaseSink and TestHBaseSink test classes need to be moved into ./plugins/hbasesink/src/javatest/... Also, there should be a way to run the tests ('ant test') in the build.xml in ./plugins/hbasesink Jon.
          Jonathan Hsieh made changes -
          Link This issue blocks FLUME-366 [ FLUME-366 ]
          Jonathan Hsieh made changes -
          Link This issue depends on FLUME-366 [ FLUME-366 ]
          Jonathan Hsieh made changes -
          Link This issue depends on FLUME-366 [ FLUME-366 ]
          Hide
          Dani Abel Rayan added a comment -

          I have also attached the corresponding patch to Flume - 366

          Show
          Dani Abel Rayan added a comment - I have also attached the corresponding patch to Flume - 366
          flume_dani made changes -
          Attachment 0004-FLUME-354-Turn-HBase-sinks-into-plugins.patch [ 10354 ]
          Attachment License Granted license to ASF [ licensed ]
          Attachment 0005-FLUME-366-In-HBase-sink-make-parameter-writeToBody-m.patch [ 10355 ]
          Attachment License Granted license to ASF [ licensed ]
          Hide
          Dani Abel Rayan added a comment -

          Please find the patches attached.

          Show
          Dani Abel Rayan added a comment - Please find the patches attached.
          Hide
          Jonathan Hsieh added a comment -

          Dani,

          I don't see a patch or a github repo branch I can pull from. Could you create a patch so I can commit?

          Thanks,
          Jon.

          Show
          Jonathan Hsieh added a comment - Dani, I don't see a patch or a github repo branch I can pull from. Could you create a patch so I can commit? Thanks, Jon.
          flume_dani made changes -
          Assignee Infantdani Abel Rayan [ flume_dani ]
          flume_dani made changes -
          Status Open [ 1 ] Patch Available [ 10000 ]
          Jonathan Hsieh made changes -
          Field Original Value New Value
          Link This issue depends on FLUME-247 [ FLUME-247 ]
          Jonathan Hsieh created issue -

            People

            • Assignee:
              Dani Abel Rayan
              Reporter:
              Jonathan Hsieh
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development