Flume
  1. Flume
  2. FLUME-322

Begin fixing issues found by pmd

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v0.9.4
    • Fix Version/s: v0.9.5
    • Component/s: None
    • Labels:
      None

      Activity

      Bruce Mitchener created issue -
      Bruce Mitchener made changes -
      Field Original Value New Value
      Attachment License Granted license to ASF [ licensed ]
      Attachment 0001-FLUME-322-Begin-fixing-issues-found-by-PMD.patch [ 10302 ]
      Hide
      Jonathan Hsieh added a comment -

      review: https://review.cloudera.org/r/1175/diff/?page=2
      Want to commit, but oddly I'm having a hard time applying the patch:

      jon@blitzwing:~/flume$ git am ~/Downloads/0001-FLUME-322-Begin-fixing-issues-found-by-PMD.patch
      Applying: FLUME-322: Begin fixing issues found by PMD.
      error: patch failed: src/java/com/cloudera/util/Benchmark.java:93
      error: src/java/com/cloudera/util/Benchmark.java: patch does not apply
      error: patch failed: src/java/com/cloudera/util/ReservoirSampler.java:81
      error: src/java/com/cloudera/util/ReservoirSampler.java: patch does not apply
      Patch failed at 0001 FLUME-322: Begin fixing issues found by PMD.
      When you have resolved this problem run "git am --resolved".
      If you would prefer to skip this patch, instead run "git am --skip".
      To restore the original branch and stop patching run "git am --abort".
      jon@blitzwing:~/flume$

      Looking at it manually I see nothing obviously strange about the changes in those two files. Can someone else try to commit? Alternately, Bruce, can you post on github so I can try to rebase from it?

      Show
      Jonathan Hsieh added a comment - review: https://review.cloudera.org/r/1175/diff/?page=2 Want to commit, but oddly I'm having a hard time applying the patch: jon@blitzwing:~/flume$ git am ~/Downloads/0001- FLUME-322 -Begin-fixing-issues-found-by-PMD.patch Applying: FLUME-322 : Begin fixing issues found by PMD. error: patch failed: src/java/com/cloudera/util/Benchmark.java:93 error: src/java/com/cloudera/util/Benchmark.java: patch does not apply error: patch failed: src/java/com/cloudera/util/ReservoirSampler.java:81 error: src/java/com/cloudera/util/ReservoirSampler.java: patch does not apply Patch failed at 0001 FLUME-322 : Begin fixing issues found by PMD. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". jon@blitzwing:~/flume$ Looking at it manually I see nothing obviously strange about the changes in those two files. Can someone else try to commit? Alternately, Bruce, can you post on github so I can try to rebase from it?
      Jonathan Hsieh made changes -
      Status Open [ 1 ] Patch Available [ 10000 ]
      Hide
      Bruce Mitchener added a comment -

      Updated and rebased against current master.

      Show
      Bruce Mitchener added a comment - Updated and rebased against current master.
      Bruce Mitchener made changes -
      Attachment License Granted license to ASF [ licensed ]
      Attachment 0001-FLUME-322-Begin-fixing-issues-found-by-PMD.patch [ 10310 ]
      Hide
      Jonathan Hsieh added a comment -

      Further investigation shows that the two files where the two changes with have problems are using windows new lines as opposed to unix newlines. Will manually fix and convert the two files to unix new lines.

      Show
      Jonathan Hsieh added a comment - Further investigation shows that the two files where the two changes with have problems are using windows new lines as opposed to unix newlines. Will manually fix and convert the two files to unix new lines.
      Hide
      Jonathan Hsieh added a comment -

      committed.

      Show
      Jonathan Hsieh added a comment - committed.
      Jonathan Hsieh made changes -
      Fix Version/s v0.9.4 [ 10050 ]
      Jonathan Hsieh made changes -
      Fix Version/s v0.9.4 [ 10050 ]
      Fix Version/s v0.9.5 [ 10090 ]
      Mark Thomas made changes -
      Project Import Tue Aug 02 16:57:12 UTC 2011 [ 1312304232406 ]
      Arvind Prabhakar made changes -
      Affects Version/s v0.9.4 [ 12317557 ]
      Hide
      Ashish Paliwal added a comment -

      Patch committed long time ago, marking as resolved

      Show
      Ashish Paliwal added a comment - Patch committed long time ago, marking as resolved
      Ashish Paliwal made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Blocked Blocked
      5d 16h 41m 1 Jonathan Hsieh 11/Nov/10 00:21
      Patch Available Patch Available Resolved Resolved
      1455d 8h 6m 1 Ashish Paliwal 05/Nov/14 08:28

        People

        • Assignee:
          Bruce Mitchener
          Reporter:
          Bruce Mitchener
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development