Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-3142 Adding HBase2 sink
  3. FLUME-3154

Add HBase client version check to AsyncHBaseSink and HBaseSink

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      Description

      The current AsyncHBase sink should run only with HBase < 2
      If it finds an incompatible HBase client on the classpath it should fail with some meaningful error message

      The same check should be performed with hbasesink

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #313 (See https://builds.apache.org/job/Flume-trunk-hbase-1/313/)
          FLUME-3154. Add HBase client version check to AsyncHBaseSink and (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a7d2a289a67f057a5cdb28dabbd3e651613dfa3e)

          • (edit) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
          • (edit) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java
          • (add) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseVersionCheck.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #313 (See https://builds.apache.org/job/Flume-trunk-hbase-1/313/ ) FLUME-3154 . Add HBase client version check to AsyncHBaseSink and (denes: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a7d2a289a67f057a5cdb28dabbd3e651613dfa3e ) (edit) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java (edit) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (add) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseVersionCheck.java
          Hide
          denes Denes Arvay added a comment -

          Thank you Miklos Csanady for the patch, Bessenyei Balázs Donát and Ferenc Szabo for the review.

          Show
          denes Denes Arvay added a comment - Thank you Miklos Csanady for the patch, Bessenyei Balázs Donát and Ferenc Szabo for the review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flume/pull/160

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flume/pull/160
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a7d2a289a67f057a5cdb28dabbd3e651613dfa3e in flume's branch refs/heads/trunk from Miklos Csanady
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a7d2a28 ]

          FLUME-3154. Add HBase client version check to AsyncHBaseSink and HBaseSink

          The current implementation of HBaseSink and AsyncHbaseSink is not
          compatible with the 2.0 version of HBase, which will be released soon.
          This change adds a check and makes these sinks fail gracefully if
          incompatible HBase jars can be found in the classpath.

          This closes #160

          Reviewers: Bessenyei Balázs Donát, Ferenc Szabo, Denes Arvay

          (Miklos Csanady via Denes Arvay)

          Show
          jira-bot ASF subversion and git services added a comment - Commit a7d2a289a67f057a5cdb28dabbd3e651613dfa3e in flume's branch refs/heads/trunk from Miklos Csanady [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a7d2a28 ] FLUME-3154 . Add HBase client version check to AsyncHBaseSink and HBaseSink The current implementation of HBaseSink and AsyncHbaseSink is not compatible with the 2.0 version of HBase, which will be released soon. This change adds a check and makes these sinks fail gracefully if incompatible HBase jars can be found in the classpath. This closes #160 Reviewers: Bessenyei Balázs Donát, Ferenc Szabo, Denes Arvay (Miklos Csanady via Denes Arvay)
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mcsanady opened a pull request:

          https://github.com/apache/flume/pull/160

          FLUME-3154: Add HBase client version check to AsyncHBaseSink and HBas…

          The current AsyncHBase and HBase sink should run only with HBase < 2
          If it finds an incompatible HBase client on the classpath it should fail with some meaningful error message

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mcsanady/flume FLUME-3154

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flume/pull/160.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #160


          commit 58c61f3366aad4cd01bcc46f119cbff2711fa969
          Author: Miklos Csanady <miklos.csanady@cloudera.com>
          Date: 2017-08-28T09:15:12Z

          FLUME-3154: Add HBase client version check to AsyncHBaseSink and HBaseSink


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mcsanady opened a pull request: https://github.com/apache/flume/pull/160 FLUME-3154 : Add HBase client version check to AsyncHBaseSink and HBas… The current AsyncHBase and HBase sink should run only with HBase < 2 If it finds an incompatible HBase client on the classpath it should fail with some meaningful error message You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcsanady/flume FLUME-3154 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flume/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit 58c61f3366aad4cd01bcc46f119cbff2711fa969 Author: Miklos Csanady <miklos.csanady@cloudera.com> Date: 2017-08-28T09:15:12Z FLUME-3154 : Add HBase client version check to AsyncHBaseSink and HBaseSink

            People

            • Assignee:
              mcsanady Miklos Csanady
              Reporter:
              mcsanady Miklos Csanady
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development