[FLUME-3043] KafkaSink SinkCallback throws NullPointerException when Log4J level is debug

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0
• Component/s: Sinks+Sources
• Assignee: dengkai
• Reporter: dengkai
• Created: 18/Jan/17 03:47
• Updated: 16/Apr/17 22:12
• Resolved: 16/Apr/17 21:29

Description

When we send a event with SinkCallback to kafka under DEBUG level of log4j, if kafka reponses a result with exception but not a RecordMetadata. Kafka Sink will throw NPE.

code in SinkCallback:

if (logger.isDebugEnabled()) {
  long eventElapsedTime = System.currentTimeMillis() - startTime;
  logger.debug("Acked message partition:{} ofset:{}",  metadata.partition(), metadata.offset());
  logger.debug("Elapsed time for send: {}", eventElapsedTime);
}

code in Kafka Producer:

if (exception == null) { 
  RecordMetadata metadata = new RecordMetadata(...);
  thunk.callback.onCompletion(metadata, null);
} else {
  thunk.callback.onCompletion(null, exception);
}

Issue Links

• links to: GitHub Pull Request #125
• links to: https://reviews.apache.org/r/55704/