Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      Description

      We've encountered an issue several times when the FileChannel wasn't able to start because of some startup-time exception.
      In this case FileChannel.open stays false false, exposing this field on JMX would make it easier to detect when the file channel hasn't been started / or has been stopped because of some reason.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #230 (See https://builds.apache.org/job/Flume-trunk-hbase-1/230/)
          FLUME-3025. Expose FileChannel.open on JMX (bessbd: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=21a64db1b0ebcb812e5c510668b580e84ff37f35)

          • (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java
          • (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
          • (add) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounter.java
          • (add) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounterMBean.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #230 (See https://builds.apache.org/job/Flume-trunk-hbase-1/230/ ) FLUME-3025 . Expose FileChannel.open on JMX (bessbd: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=21a64db1b0ebcb812e5c510668b580e84ff37f35 ) (edit) flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java (edit) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java (add) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounter.java (add) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounterMBean.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flume/pull/85

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flume/pull/85
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 21a64db1b0ebcb812e5c510668b580e84ff37f35 in flume's branch refs/heads/trunk from Denes Arvay
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=21a64db ]

          FLUME-3025. Expose FileChannel.open on JMX

          This patch exposes the FileChannel's open flag on JMX to make it possible to detect when it wasn't able to start up. In those cases the open flag is false.

          This closes #85

          Reviewers: Attila Simon, Bessenyei Balázs Donát

          (Denes Arvay via Bessenyei Balázs Donát)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 21a64db1b0ebcb812e5c510668b580e84ff37f35 in flume's branch refs/heads/trunk from Denes Arvay [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=21a64db ] FLUME-3025 . Expose FileChannel.open on JMX This patch exposes the FileChannel's open flag on JMX to make it possible to detect when it wasn't able to start up. In those cases the open flag is false. This closes #85 Reviewers: Attila Simon, Bessenyei Balázs Donát (Denes Arvay via Bessenyei Balázs Donát)
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user adenes opened a pull request:

          https://github.com/apache/flume/pull/85

          FLUME-3025: Expose FileChannel.open JMX

          This patch exposes the `FileChannel`'s `open` flag on JMX to make it possible to detect when it wasn't able to start up (thus its `open` flag is `false`).

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/adenes/flume expose-filechannel-open-jmx

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flume/pull/85.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #85


          commit ec250a672523ef36a72b6ebbcdd9c7ecfab39447
          Author: Denes Arvay <denes@cloudera.com>
          Date: 2016-11-15T16:21:12Z

          Expose FileChannel.open on JMX

          commit b6330e7366079f581e6d4d1ade9a97c1067f0bb1
          Author: Denes Arvay <denes@cloudera.com>
          Date: 2016-11-16T15:44:06Z

          Add test for FileChannelCounter.isOpen()


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user adenes opened a pull request: https://github.com/apache/flume/pull/85 FLUME-3025 : Expose FileChannel.open JMX This patch exposes the `FileChannel`'s `open` flag on JMX to make it possible to detect when it wasn't able to start up (thus its `open` flag is `false`). You can merge this pull request into a Git repository by running: $ git pull https://github.com/adenes/flume expose-filechannel-open-jmx Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flume/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit ec250a672523ef36a72b6ebbcdd9c7ecfab39447 Author: Denes Arvay <denes@cloudera.com> Date: 2016-11-15T16:21:12Z Expose FileChannel.open on JMX commit b6330e7366079f581e6d4d1ade9a97c1067f0bb1 Author: Denes Arvay <denes@cloudera.com> Date: 2016-11-16T15:44:06Z Add test for FileChannelCounter.isOpen()

            People

            • Assignee:
              denes Denes Arvay
              Reporter:
              denes Denes Arvay
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development