Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.0
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Now that style violations fail Flume build process, Flume fails to build on Windows.
      The reason for that is that file paths in checkstyle-suppressions.xml are written with non-portable separators. Switching to "[/
      ]" as a path separator, should fix this issue.
      References:

        Activity

        Hide
        mpercy Mike Percy added a comment -

        +1. I did not test this myself because I don't run Windows but it LGTM.

        Show
        mpercy Mike Percy added a comment - +1. I did not test this myself because I don't run Windows but it LGTM.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 188c3104ab6030c40d652595a2274527a4ad4105 in flume's branch refs/heads/trunk from Mike Percy
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=188c310 ]

        FLUME-2949. checkstyle: Make suppressions compatible with Windows

        File paths in checkstyle-suppressions.xml are written with non-portable
        separators. Switching to "[/
        ]" as a path separator should fix this
        issue.

        (Lior Zeno via Mike Percy)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 188c3104ab6030c40d652595a2274527a4ad4105 in flume's branch refs/heads/trunk from Mike Percy [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=188c310 ] FLUME-2949 . checkstyle: Make suppressions compatible with Windows File paths in checkstyle-suppressions.xml are written with non-portable separators. Switching to "[/ ]" as a path separator should fix this issue. (Lior Zeno via Mike Percy)
        Hide
        mpercy Mike Percy added a comment -

        Pushed to trunk. Thanks for the patch, Lior!

        Show
        mpercy Mike Percy added a comment - Pushed to trunk. Thanks for the patch, Lior!
        Hide
        mpercy Mike Percy added a comment -

        Note: On commit, I added a small comment at the top of the suppressions file to explain the strange syntax.

        Show
        mpercy Mike Percy added a comment - Note: On commit, I added a small comment at the top of the suppressions file to explain the strange syntax.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Flume-trunk-hbase-1 #174 (See https://builds.apache.org/job/Flume-trunk-hbase-1/174/)
        FLUME-2949. checkstyle: Make suppressions compatible with Windows (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=188c3104ab6030c40d652595a2274527a4ad4105)

        • flume-checkstyle/src/main/resources/flume/checkstyle-suppressions.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Flume-trunk-hbase-1 #174 (See https://builds.apache.org/job/Flume-trunk-hbase-1/174/ ) FLUME-2949 . checkstyle: Make suppressions compatible with Windows (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=188c3104ab6030c40d652595a2274527a4ad4105 ) flume-checkstyle/src/main/resources/flume/checkstyle-suppressions.xml

          People

          • Assignee:
            liorze Lior Zeno
            Reporter:
            liorze Lior Zeno
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development