Flume
  1. Flume
  2. FLUME-292

Refactor OutputFormat and OutputFormatBuilder to better support plugin authoring

    Details

      Description

      OutputFormat and OutputFormatBuilder usage has been inconsistent and required multiple places where information was repeated. Both should be refactored, as well as their consumers, such that:

      • Instantiation / building of OutputFormats is consistent within the code base.
      • OutputFormat names can be centralized and reused.
      • Each class conforms to the "do one thing and do it well" rule.

        Issue Links

          Activity

          Hide
          E. Sammer added a comment -

          I can't post the review just yet because RB is complaining my flume-195 branch blobs aren't in the repo (which is true) yet. This patch is on top of the FLUME-195 patch set so I have to get that through first.

          Show
          E. Sammer added a comment - I can't post the review just yet because RB is complaining my flume-195 branch blobs aren't in the repo (which is true) yet. This patch is on top of the FLUME-195 patch set so I have to get that through first.
          Hide
          Disabled imported user added a comment -

          If you can push to a branch, I think RB will eventually pull it and you can upload the diff.

          Show
          Disabled imported user added a comment - If you can push to a branch, I think RB will eventually pull it and you can upload the diff.
          Hide
          E. Sammer added a comment -

          Thanks Henry. I did exactly that.

          https://review.cloudera.org/r/1085/

          Show
          E. Sammer added a comment - Thanks Henry. I did exactly that. https://review.cloudera.org/r/1085/
          Hide
          E. Sammer added a comment -

          Pushed to master.

          Show
          E. Sammer added a comment - Pushed to master.

            People

            • Assignee:
              E. Sammer
              Reporter:
              E. Sammer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development