Flume
  1. Flume
  2. FLUME-2797

SyslogTcpSource uses Deprecated Class + Deprecate SyslogTcpSource

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      From the mailing list:

      From Ashish:
      Source uses an deprecated class. Can you please file a JIRA for this?

      The fix is simple. In SyslogTcpSource Line#61, replace the
      CounterGroup usage with SourceCounter and make related changes in
      code. You can refer other Sources for details. Same is applicable for
      SyslogUDPSource.

      From Hari:
      I think the Syslog TCP source should be deprecated in favor of the Multiport Syslog Source - that is more stable and gives better performance too.

      1. FLUME-2797-0.patch
        6 kB
        Lior Zeno
      2. FLUME-2797-2.patch
        14 kB
        Denes Arvay
      3. FLUME-2797-3.patch
        13 kB
        Denes Arvay
      4. FLUME-2797-4.patch
        12 kB
        Denes Arvay
      5. FLUME-2797-5.patch
        12 kB
        Denes Arvay
      6. FLUME-2797-6.patch
        14 kB
        Denes Arvay

        Issue Links

          Activity

          Hide
          Lior Zeno added a comment -

          +1 for Hari's suggestion. In our documentation we also mention that (the Multiport Syslog Source) "This is a newer, faster, multi-port capable version of the Syslog TCP source."

          Show
          Lior Zeno added a comment - +1 for Hari's suggestion. In our documentation we also mention that (the Multiport Syslog Source) "This is a newer, faster, multi-port capable version of the Syslog TCP source."
          Hide
          Denes Arvay added a comment -

          Hi Otis Gospodnetic, thanks for the patch. It's quite an old issue but I've just bumped into a problem which could be solved by this change so I'd be happy to review it. Could you please submit your patch to the reviewboard? Thank you.

          Show
          Denes Arvay added a comment - Hi Otis Gospodnetic , thanks for the patch. It's quite an old issue but I've just bumped into a problem which could be solved by this change so I'd be happy to review it. Could you please submit your patch to the reviewboard? Thank you.
          Hide
          Otis Gospodnetic added a comment -

          We re not using Flume any more, so somebody else please take over.

          Show
          Otis Gospodnetic added a comment - We re not using Flume any more, so somebody else please take over.
          Hide
          Denes Arvay added a comment -

          Ok, thanks for the reply.

          Show
          Denes Arvay added a comment - Ok, thanks for the reply.
          Hide
          Denes Arvay added a comment -

          new patch: test logging statement removed, thanks Attila Simon for the review

          Show
          Denes Arvay added a comment - new patch: test logging statement removed, thanks Attila Simon for the review
          Hide
          Denes Arvay added a comment -

          Patch updated, thanks Bessenyei Balázs Donát for the review.

          Show
          Denes Arvay added a comment - Patch updated, thanks Bessenyei Balázs Donát for the review.
          Hide
          Denes Arvay added a comment -

          Thanks Mike Percy for the review, I've uploaded a new patch.

          Show
          Denes Arvay added a comment - Thanks Mike Percy for the review, I've uploaded a new patch.
          Hide
          Mike Percy added a comment -

          +1. I am about to commit this.

          Show
          Mike Percy added a comment - +1. I am about to commit this.
          Hide
          ASF subversion and git services added a comment -

          Commit d9c9a7dd9a6889ecf6b9dc88fb8e02ccc1cd5167 in flume's branch refs/heads/trunk from Denes Arvay
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=d9c9a7d ]

          FLUME-2797. Use SourceCounter for SyslogTcpSource

          This patch uses the newer SourceCounter class for the SyslogTcpSource.
          It also marks the SyslogTcpSource as deprecated and improves how the
          unit tests are written so they don't require DNS.

          Reviewers: Attila Simon, Lior Zeno, Balázs Donát Bessenyei, Mike Percy

          (Denes Arvay via Mike Percy)

          Show
          ASF subversion and git services added a comment - Commit d9c9a7dd9a6889ecf6b9dc88fb8e02ccc1cd5167 in flume's branch refs/heads/trunk from Denes Arvay [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=d9c9a7d ] FLUME-2797 . Use SourceCounter for SyslogTcpSource This patch uses the newer SourceCounter class for the SyslogTcpSource. It also marks the SyslogTcpSource as deprecated and improves how the unit tests are written so they don't require DNS. Reviewers: Attila Simon, Lior Zeno, Balázs Donát Bessenyei, Mike Percy (Denes Arvay via Mike Percy)
          Hide
          Mike Percy added a comment -

          Pushed to trunk. Thanks for the patch, Denes!

          Show
          Mike Percy added a comment - Pushed to trunk. Thanks for the patch, Denes!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #204 (See https://builds.apache.org/job/Flume-trunk-hbase-1/204/)
          FLUME-2797. Use SourceCounter for SyslogTcpSource (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d9c9a7dd9a6889ecf6b9dc88fb8e02ccc1cd5167)

          • (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
          • (edit) flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
          • (edit) flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
          • (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Jenkins build Flume-trunk-hbase-1 #204 (See https://builds.apache.org/job/Flume-trunk-hbase-1/204/ ) FLUME-2797 . Use SourceCounter for SyslogTcpSource (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=d9c9a7dd9a6889ecf6b9dc88fb8e02ccc1cd5167 ) (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java (edit) flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java (edit) flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java (edit) flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java

            People

            • Assignee:
              Denes Arvay
              Reporter:
              Otis Gospodnetic
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development