Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2732

Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      In AsyncHbaseSink, the maximum consecutive transaction failures, after which we shutdown the HbaseClient and recreate the client, is currently hardcoded to 10. (This change was introduced to overcome a Memory leak in AsyncHbaseClient)
      This needs to be configurable, and defaulted to 0 (Unlimited)
      The reason for this change is to overcome a bug in the AsyncHbaseClient, that starts leaking File Descriptors on shutdown.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Flume-trunk-hbase-1 #109 (See https://builds.apache.org/job/Flume-trunk-hbase-1/109/)
        FLUME-2732. Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=48126c235c73c67d9c3c2084df122fc96fd2064d)

        • flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java
        • flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-1 #109 (See https://builds.apache.org/job/Flume-trunk-hbase-1/109/ ) FLUME-2732 . Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=48126c235c73c67d9c3c2084df122fc96fd2064d ) flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed! Thanks Johny!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed! Thanks Johny!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 48126c235c73c67d9c3c2084df122fc96fd2064d in flume's branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=48126c2 ]

        FLUME-2732. Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 48126c235c73c67d9c3c2084df122fc96fd2064d in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=48126c2 ] FLUME-2732 . Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable (Johny Rufus via Hari)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 200e6dcbf92e196a6f647a909a9a5cdae1fa0c0f in flume's branch refs/heads/flume-1.7 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=200e6dc ]

        FLUME-2732. Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 200e6dcbf92e196a6f647a909a9a5cdae1fa0c0f in flume's branch refs/heads/flume-1.7 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=200e6dc ] FLUME-2732 . Make maximum tolerated failures before shutting down and recreating client in AsyncHbaseSink configurable (Johny Rufus via Hari)
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Looks good

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Looks good
        Hide
        jrufus Johny Rufus added a comment -

        Attached patch, which makes the maximum consecutive hbase failures configurable

        Show
        jrufus Johny Rufus added a comment - Attached patch, which makes the maximum consecutive hbase failures configurable

          People

          • Assignee:
            jrufus Johny Rufus
            Reporter:
            jrufus Johny Rufus
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development