Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2654

Memory channel error message related to byteCapacity needs refining

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.6.0
        • Component/s: None
        • Labels:
          None

          Description

          Memory channel error message thrown in doCommit, when space runs out, mentions heap space as byteCapacity, but this value is not the actual heap capacity, as it goes through a set of transformations and gets divided by byteCapacitySlotSize

          So we need to refine the message a bit to reflect this, otherwise the user is mislead about the configured heap size

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jrufus Johny Rufus added a comment -

            Patch with modified error message

            Show
            jrufus Johny Rufus added a comment - Patch with modified error message
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            +1. Running tests and committing.

            Show
            hshreedharan Hari Shreedharan added a comment - +1. Running tests and committing.
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit cfefda167ea42aa5d68e15ac55bc2d6394c2d48d in flume's branch refs/heads/trunk from Hari Shreedharan
            [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=cfefda1 ]

            FLUME-2654. Clarify error message in MemoryChannel when byte capacity is reached.

            (Johny Rufus via Hari)

            Show
            jira-bot ASF subversion and git services added a comment - Commit cfefda167ea42aa5d68e15ac55bc2d6394c2d48d in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=cfefda1 ] FLUME-2654 . Clarify error message in MemoryChannel when byte capacity is reached. (Johny Rufus via Hari)
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit cc13102a3ba8cb54d2d2c322a5ef149876382f28 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
            [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=cc13102 ]

            FLUME-2654. Clarify error message in MemoryChannel when byte capacity is reached.

            (Johny Rufus via Hari)

            Show
            jira-bot ASF subversion and git services added a comment - Commit cc13102a3ba8cb54d2d2c322a5ef149876382f28 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=cc13102 ] FLUME-2654 . Clarify error message in MemoryChannel when byte capacity is reached. (Johny Rufus via Hari)
            Hide
            Permalink
            hshreedharan Hari Shreedharan added a comment -

            Committed! Thanks Johny!

            Show
            hshreedharan Hari Shreedharan added a comment - Committed! Thanks Johny!
            Hide
            Permalink
            hudson Hudson added a comment -

            UNSTABLE: Integrated in flume-trunk #727 (See https://builds.apache.org/job/flume-trunk/727/)
            FLUME-2654. Clarify error message in MemoryChannel when byte capacity is reached. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=cfefda167ea42aa5d68e15ac55bc2d6394c2d48d)

            • flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
            Show
            hudson Hudson added a comment - UNSTABLE: Integrated in flume-trunk #727 (See https://builds.apache.org/job/flume-trunk/727/ ) FLUME-2654 . Clarify error message in MemoryChannel when byte capacity is reached. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=cfefda167ea42aa5d68e15ac55bc2d6394c2d48d ) flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Flume-trunk-hbase-98 #84 (See https://builds.apache.org/job/Flume-trunk-hbase-98/84/)
            FLUME-2654. Clarify error message in MemoryChannel when byte capacity is reached. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=cfefda167ea42aa5d68e15ac55bc2d6394c2d48d)

            • flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-98 #84 (See https://builds.apache.org/job/Flume-trunk-hbase-98/84/ ) FLUME-2654 . Clarify error message in MemoryChannel when byte capacity is reached. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=cfefda167ea42aa5d68e15ac55bc2d6394c2d48d ) flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java

              People

              • Assignee:
                jrufus Johny Rufus
                Reporter:
                jrufus Johny Rufus
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development