Attached patch that removes trustmanager-type from ThriftRpcClient
and keymanager-type from ThriftSource

Can we do the same thing we do in Avro Source? Check out that is being done there, we should probably do the same thing.

Hari Shreedharan, is there any specific reason why we need to use "SunX509" ? This wont work for IBM JRE ?
Is not the best thing to do is to use the defaultKeyManagerAlgorithm, for Sun it will default to SunX509 and for IBM it will default to IbmX509

Included reading from the property before defaulting

I don't remember exactly, but I believe it is a part of the standard. If you go back and look at the jira that added this for Avro Source you should be able to see the discussion there.

Btw, you don't need to specifically use SunX509 (sorry, misread your comment, I thought you were using default anyway) - your implementation looks good.

+1. Running tests.

Acutally one question - why are we not trying to get what it from the security properties and then choosing the default in the client, rather than directly choosing the default?

Also tmf is declared and assigned separately in client - why not simply assign it in the declaration itself and make it final?

Avro source/sink has a similar structure, the source tries to read from a property and if not resorts to default value, the sink only uses the default.

SUCCESS: Integrated in flume-trunk #722 (See https://builds.apache.org/job/flume-trunk/722/)
FLUME-2626. Remove trustmanager-type from Thrift RPC client and Thrift Source. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e60c22a318f7c4fe3868a3ad762e3998f61b49d7)

• flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
• flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java

SUCCESS: Integrated in Flume-trunk-hbase-98 #79 (See https://builds.apache.org/job/Flume-trunk-hbase-98/79/)
FLUME-2626. Remove trustmanager-type from Thrift RPC client and Thrift Source. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e60c22a318f7c4fe3868a3ad762e3998f61b49d7)

• flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java
• flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java

Patch committed, hence resolving.