Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2626

Remove trustmanager-type from Thrift RPC client

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None
    1. FLUME-2626.patch
      5 kB
      Johny Rufus
    2. FLUME-2626-1.patch
      5 kB
      Johny Rufus

      Activity

      Hide
      jrufus Johny Rufus added a comment -

      Patch committed, hence resolving.

      Show
      jrufus Johny Rufus added a comment - Patch committed, hence resolving.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Flume-trunk-hbase-98 #79 (See https://builds.apache.org/job/Flume-trunk-hbase-98/79/)
      FLUME-2626. Remove trustmanager-type from Thrift RPC client and Thrift Source. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e60c22a318f7c4fe3868a3ad762e3998f61b49d7)

      • flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java
      • flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-98 #79 (See https://builds.apache.org/job/Flume-trunk-hbase-98/79/ ) FLUME-2626 . Remove trustmanager-type from Thrift RPC client and Thrift Source. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e60c22a318f7c4fe3868a3ad762e3998f61b49d7 ) flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in flume-trunk #722 (See https://builds.apache.org/job/flume-trunk/722/)
      FLUME-2626. Remove trustmanager-type from Thrift RPC client and Thrift Source. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e60c22a318f7c4fe3868a3ad762e3998f61b49d7)

      • flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
      • flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #722 (See https://builds.apache.org/job/flume-trunk/722/ ) FLUME-2626 . Remove trustmanager-type from Thrift RPC client and Thrift Source. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e60c22a318f7c4fe3868a3ad762e3998f61b49d7 ) flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java
      Hide
      jrufus Johny Rufus added a comment -

      Avro source/sink has a similar structure, the source tries to read from a property and if not resorts to default value, the sink only uses the default.

      Show
      jrufus Johny Rufus added a comment - Avro source/sink has a similar structure, the source tries to read from a property and if not resorts to default value, the sink only uses the default.
      Hide
      hshreedharan Hari Shreedharan added a comment -

      Acutally one question - why are we not trying to get what it from the security properties and then choosing the default in the client, rather than directly choosing the default?

      Also tmf is declared and assigned separately in client - why not simply assign it in the declaration itself and make it final?

      Show
      hshreedharan Hari Shreedharan added a comment - Acutally one question - why are we not trying to get what it from the security properties and then choosing the default in the client, rather than directly choosing the default? Also tmf is declared and assigned separately in client - why not simply assign it in the declaration itself and make it final?
      Hide
      hshreedharan Hari Shreedharan added a comment -

      Btw, you don't need to specifically use SunX509 (sorry, misread your comment, I thought you were using default anyway) - your implementation looks good.

      +1. Running tests.

      Show
      hshreedharan Hari Shreedharan added a comment - Btw, you don't need to specifically use SunX509 (sorry, misread your comment, I thought you were using default anyway) - your implementation looks good. +1. Running tests.
      Hide
      hshreedharan Hari Shreedharan added a comment -

      I don't remember exactly, but I believe it is a part of the standard. If you go back and look at the jira that added this for Avro Source you should be able to see the discussion there.

      Show
      hshreedharan Hari Shreedharan added a comment - I don't remember exactly, but I believe it is a part of the standard. If you go back and look at the jira that added this for Avro Source you should be able to see the discussion there.
      Hide
      jrufus Johny Rufus added a comment -

      Included reading from the property before defaulting

      Show
      jrufus Johny Rufus added a comment - Included reading from the property before defaulting
      Hide
      jrufus Johny Rufus added a comment -

      Hari Shreedharan, is there any specific reason why we need to use "SunX509" ? This wont work for IBM JRE ?
      Is not the best thing to do is to use the defaultKeyManagerAlgorithm, for Sun it will default to SunX509 and for IBM it will default to IbmX509

      Show
      jrufus Johny Rufus added a comment - Hari Shreedharan , is there any specific reason why we need to use "SunX509" ? This wont work for IBM JRE ? Is not the best thing to do is to use the defaultKeyManagerAlgorithm, for Sun it will default to SunX509 and for IBM it will default to IbmX509
      Hide
      hshreedharan Hari Shreedharan added a comment -

      Can we do the same thing we do in Avro Source? Check out that is being done there, we should probably do the same thing.

      Show
      hshreedharan Hari Shreedharan added a comment - Can we do the same thing we do in Avro Source? Check out that is being done there, we should probably do the same thing.
      Hide
      jrufus Johny Rufus added a comment -

      Attached patch that removes trustmanager-type from ThriftRpcClient
      and keymanager-type from ThriftSource

      Show
      jrufus Johny Rufus added a comment - Attached patch that removes trustmanager-type from ThriftRpcClient and keymanager-type from ThriftSource

        People

        • Assignee:
          jrufus Johny Rufus
          Reporter:
          hshreedharan Hari Shreedharan
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development