Nice catch, SpoolDir should specifically catch ChannelFullException instead of catching ChannelException and deciding that the channel is Full.
Had to make one more change in ChannelProcessor, to not over wrap a ChannelException with itself

There is one more place in ChannelProcessor, where this should be handled, including that change too

Why do you need this change:

if (t instanceof ChannelException) {
  throw (ChannelException)t;
}

ChannelException is unchecked, so you don't need that cast. I don't see any benefit of doing this, since a catch for ChannelException will catch it even without the cast here. Am I missing something? You can just throw it as is no?

t is of type Throwable, so if we just use - throw t, then @ compile time it would expect Throwable to be caught or declared as thrown, hence the cast

Johny Rufus: as there has been no updates for about a year, I'm assigning this ticket to me. If you disagree, please do tell.

I have rebased this patch on trunk. Please, review it at https://reviews.apache.org/r/50232/

The patch for this issue has been available for a while, but it needs some reviews to be committed to trunk.

Is there anyone who could help with this?

+1. I am about to commit this.

Commit 1422f733007dbb78caae7e5135bc33470e88502a in flume's branch refs/heads/trunk from Bessenyei Balázs Donát
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=1422f73 ]

FLUME-2619. Spooldir source should log channel exceptions

Reviewed by Denes Arvay and Mike Percy.

(Bessenyei Balázs Donát via Mike Percy)

Pushed to trunk. Thanks for the patch Donat!

FAILURE: Integrated in Flume-trunk-hbase-1 #192 (See https://builds.apache.org/job/Flume-trunk-hbase-1/192/)
FLUME-2619. Spooldir source should log channel exceptions (mpercy: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=1422f733007dbb78caae7e5135bc33470e88502a)

• flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java
• flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java
• flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java