Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.5.2
-
Fix Version/s: 1.7.0
-
Component/s: None
-
Labels:None
Description
the int value returned from the method should be in range 0-255 for a byte read, or -1 when EOF was reached, as described in InputStream class javadoc.
Fix is to change the line in read() method:
return byteBuf[0];
to
return byteBuf[0] & 0xFF;
Issue Links
- is duplicated by
-
FLUME-2074
ResettableInputStream returns Signed Data when parsing binary stream
-
- Open
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
patch attached
+1, it would be good to add a test case that makes sure the behavior is consistent with FileInputStream
new patch with jUnit attached
Johny Rufus any further change needed?
Miroslav Holubec, Thanks for the patch with test case, running tests now, will commit today
Commit 0e40e831108f34b5bc6d01bf1ffa9efae330ea82 in flume's branch refs/heads/trunk from Johny Rufus
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=0e40e83 ]
FLUME-2593. ResettableFileInputStream returns negate values from read() method
(Miroslav Holubec via Johny Rufus)
Commit 589bfa202fbbe8b862f8ee943b81d0e1ea2d670b in flume's branch refs/heads/flume-1.7 from Johny Rufus
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=589bfa2 ]
FLUME-2593. ResettableFileInputStream returns negate values from read() method
(Miroslav Holubec via Johny Rufus)
Thanks for the patch Miroslav Holubec !!
UNSTABLE: Integrated in Flume-trunk-hbase-1 #131 (See https://builds.apache.org/job/Flume-trunk-hbase-1/131/)
FLUME-2593. ResettableFileInputStream returns negate values from read() (johnyrufus: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=0e40e831108f34b5bc6d01bf1ffa9efae330ea82)
- flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java
- flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java
Can this issue be fixed in 1.5 version too, please?
Do you have a patch?