Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2592

Specify main manifest attribute in flume tools jar

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      flume-tools is missing main manifest attribute, which causes the failure to launch flume tools. Running it results in following error

      bash-3.2$ java -jar flume-tools-1.6.0-SNAPSHOT.jar -h
      no main manifest attribute, in flume-tools-1.6.0-SNAPSHOT.jar

      The help option printed also misses the jar to be used
      usage: java -jar fcintegritytool [-h] [-l <arg>]
      h,-help Display help
      l,-dataDirs <arg> Comma-separated list of data directories which the
      tool must verify. This option is mandatory

      Using the following usage option results in "Error: Unable to access jarfile fcintegritytool"

      1. FLUME-2592-0.patch
        1 kB
        Ashish Paliwal

        Issue Links

          Activity

          Hide
          paliwalashish Ashish Paliwal added a comment -

          Looked at the code, tool can be run from flume-ng script. The help message needs to be fixed. Options are either we point it to use the flume-ng script or can leave it to run as standalone file by modifying pom.xml (painful with classpath settings and all).

          Hari Shreedharan/Roshan Naik Suggestions on fixing this?

          Show
          paliwalashish Ashish Paliwal added a comment - Looked at the code, tool can be run from flume-ng script. The help message needs to be fixed. Options are either we point it to use the flume-ng script or can leave it to run as standalone file by modifying pom.xml (painful with classpath settings and all). Hari Shreedharan / Roshan Naik Suggestions on fixing this?
          Hide
          hshreedharan Hari Shreedharan added a comment -

          The tool works fine. The help message is actually pretty broken - sorry! I don't mind integrating it in the flume-ng script.

          Show
          hshreedharan Hari Shreedharan added a comment - The tool works fine. The help message is actually pretty broken - sorry! I don't mind integrating it in the flume-ng script.
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Cool, Shall add the help message to the way to run it using flume-ng script (as in user guide). Patch coming in few hours

          Show
          paliwalashish Ashish Paliwal added a comment - Cool, Shall add the help message to the way to run it using flume-ng script (as in user guide). Patch coming in few hours
          Hide
          hshreedharan Hari Shreedharan added a comment -

          +1. Committing now.

          Show
          hshreedharan Hari Shreedharan added a comment - +1. Committing now.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6f6f69b8b3435385b578af4bfb7790f2984bfb35 in flume's branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6f6f69b ]

          FLUME-2592. Fix help message in File Channel Integrity Tool.

          (Ashish Paliwal via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6f6f69b8b3435385b578af4bfb7790f2984bfb35 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6f6f69b ] FLUME-2592 . Fix help message in File Channel Integrity Tool. (Ashish Paliwal via Hari)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3e75dc58ae85101dcb166d99056c2f3e4523f002 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=3e75dc5 ]

          FLUME-2592. Fix help message in File Channel Integrity Tool.

          (Ashish Paliwal via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3e75dc58ae85101dcb166d99056c2f3e4523f002 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=3e75dc5 ] FLUME-2592 . Fix help message in File Channel Integrity Tool. (Ashish Paliwal via Hari)
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Committed! Thanks Ashish!

          Show
          hshreedharan Hari Shreedharan added a comment - Committed! Thanks Ashish!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Flume-trunk-hbase-98 #71 (See https://builds.apache.org/job/Flume-trunk-hbase-98/71/)
          FLUME-2592. Fix help message in File Channel Integrity Tool. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=6f6f69b8b3435385b578af4bfb7790f2984bfb35)

          • flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-98 #71 (See https://builds.apache.org/job/Flume-trunk-hbase-98/71/ ) FLUME-2592 . Fix help message in File Channel Integrity Tool. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=6f6f69b8b3435385b578af4bfb7790f2984bfb35 ) flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in flume-trunk #714 (See https://builds.apache.org/job/flume-trunk/714/)
          FLUME-2592. Fix help message in File Channel Integrity Tool. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=6f6f69b8b3435385b578af4bfb7790f2984bfb35)

          • flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in flume-trunk #714 (See https://builds.apache.org/job/flume-trunk/714/ ) FLUME-2592 . Fix help message in File Channel Integrity Tool. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=6f6f69b8b3435385b578af4bfb7790f2984bfb35 ) flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java

            People

            • Assignee:
              paliwalashish Ashish Paliwal
              Reporter:
              paliwalashish Ashish Paliwal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development