Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Current Thrift Source/Sink does not have support for SSL. Similar to Avro we should start supporting SSL for Thrift based communication

      1. FLUME-2574.patch
        36 kB
        Johny Rufus
      2. FLUME-2574-1.patch
        37 kB
        Johny Rufus
      3. FLUME-2574-2.patch
        36 kB
        Johny Rufus

        Activity

        Hide
        jrufus Johny Rufus added a comment -

        Attaching patch with the changes needed to support SSL in Thrift Src/Sink

        Show
        jrufus Johny Rufus added a comment - Attaching patch with the changes needed to support SSL in Thrift Src/Sink
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Johny, could you please upload this to review board? Thanks!

        Show
        hshreedharan Hari Shreedharan added a comment - Johny, could you please upload this to review board? Thanks!
        Hide
        jrufus Johny Rufus added a comment -
        Show
        jrufus Johny Rufus added a comment - Hari Shreedharan , Review request : https://reviews.apache.org/r/30301/
        Hide
        jrufus Johny Rufus added a comment -

        Hari Shreedharan, Attaching patch with review comments incorporated

        Show
        jrufus Johny Rufus added a comment - Hari Shreedharan , Attaching patch with review comments incorporated
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Can you please update the review request?

        Show
        hshreedharan Hari Shreedharan added a comment - Can you please update the review request?
        Hide
        jrufus Johny Rufus added a comment -

        Uploaded to the review request. Thanks.

        Show
        jrufus Johny Rufus added a comment - Uploaded to the review request. Thanks.
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Hmm, I don't see the update on review board. Can you check if you can see it?

        Show
        hshreedharan Hari Shreedharan added a comment - Hmm, I don't see the update on review board. Can you check if you can see it?
        Hide
        jrufus Johny Rufus added a comment -

        Attaching patch with all the review changes.

        Show
        jrufus Johny Rufus added a comment - Attaching patch with all the review changes.
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Looks good to me.

        I have one followup item - Is there a reason the trust manager type is being taken in as a config parameter? In case of the Avro RPC client, we just use SunX509, why not do the same here?

        I will commit this, but we should figure out this config param in a follow up jira.

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Looks good to me. I have one followup item - Is there a reason the trust manager type is being taken in as a config parameter? In case of the Avro RPC client, we just use SunX509, why not do the same here? I will commit this, but we should figure out this config param in a follow up jira.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a103a677145a43aa6fa78dfeeb34018879e24a94 in flume's branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a103a67 ]

        FLUME-2574. SSL support for Thrift RPC.

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit a103a677145a43aa6fa78dfeeb34018879e24a94 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=a103a67 ] FLUME-2574 . SSL support for Thrift RPC. (Johny Rufus via Hari)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 25013c48c6d78b02586da2063cc44883cb651a07 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=25013c4 ]

        FLUME-2574. SSL support for Thrift RPC.

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 25013c48c6d78b02586da2063cc44883cb651a07 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=25013c4 ] FLUME-2574 . SSL support for Thrift RPC. (Johny Rufus via Hari)
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in flume-trunk #715 (See https://builds.apache.org/job/flume-trunk/715/)
        FLUME-2574. SSL support for Thrift RPC. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a103a677145a43aa6fa78dfeeb34018879e24a94)

        • flume-ng-sdk/src/test/java/org/apache/flume/api/ThriftTestingSource.java
        • flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
        • flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java
        • flume-ng-core/src/test/resources/truststorefile.jks
        • flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java
        • flume-ng-core/src/test/resources/keystorefile.jks
        • flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in flume-trunk #715 (See https://builds.apache.org/job/flume-trunk/715/ ) FLUME-2574 . SSL support for Thrift RPC. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a103a677145a43aa6fa78dfeeb34018879e24a94 ) flume-ng-sdk/src/test/java/org/apache/flume/api/ThriftTestingSource.java flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java flume-ng-core/src/test/resources/truststorefile.jks flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java flume-ng-core/src/test/resources/keystorefile.jks flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Flume-trunk-hbase-98 #72 (See https://builds.apache.org/job/Flume-trunk-hbase-98/72/)
        FLUME-2574. SSL support for Thrift RPC. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a103a677145a43aa6fa78dfeeb34018879e24a94)

        • flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java
        • flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java
        • flume-ng-core/src/test/resources/keystorefile.jks
        • flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java
        • flume-ng-sdk/src/test/java/org/apache/flume/api/ThriftTestingSource.java
        • flume-ng-core/src/test/resources/truststorefile.jks
        • flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Flume-trunk-hbase-98 #72 (See https://builds.apache.org/job/Flume-trunk-hbase-98/72/ ) FLUME-2574 . SSL support for Thrift RPC. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=a103a677145a43aa6fa78dfeeb34018879e24a94 ) flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java flume-ng-core/src/test/resources/keystorefile.jks flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java flume-ng-sdk/src/test/java/org/apache/flume/api/ThriftTestingSource.java flume-ng-core/src/test/resources/truststorefile.jks flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java

          People

          • Assignee:
            jrufus Johny Rufus
            Reporter:
            jrufus Johny Rufus
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development