Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2568

Additional fix for TestReliableSpoolingFileEventReader

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      TestReliableSpoolingFileEventReader needs some more modification in addition to the fix provided in FLUME-2505
      1) Needed to add semaphore2 to ensure that new file gets created before the second listing, without this readEventsForFilesInDir() can complete before the new file gets created
      2) had to remove renameTo and instead create the newfile, for the directory listing to pick the new file

        Activity

        Hide
        jrufus Johny Rufus added a comment - - edited

        Attaching a patch, that takes care of the failing test

        Show
        jrufus Johny Rufus added a comment - - edited Attaching a patch, that takes care of the failing test
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Johny Rufus Can you please put in a more detailed description?

        Show
        hshreedharan Hari Shreedharan added a comment - Johny Rufus Can you please put in a more detailed description?
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Looks good, committing once tests pass.

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Looks good, committing once tests pass.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 91c58804da51a551fcbbe290261810c7750ee749 in flume's branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=91c5880 ]

        FLUME-2568. Additional fix for TestReliableSpoolingFileEventReader

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 91c58804da51a551fcbbe290261810c7750ee749 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=91c5880 ] FLUME-2568 . Additional fix for TestReliableSpoolingFileEventReader (Johny Rufus via Hari)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6e9d1082e44093265af9d8e16f00b725f66ec1dc in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6e9d108 ]

        FLUME-2568. Additional fix for TestReliableSpoolingFileEventReader

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6e9d1082e44093265af9d8e16f00b725f66ec1dc in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6e9d108 ] FLUME-2568 . Additional fix for TestReliableSpoolingFileEventReader (Johny Rufus via Hari)
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed! Thanks Johny!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed! Thanks Johny!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #707 (See https://builds.apache.org/job/flume-trunk/707/)
        FLUME-2568. Additional fix for TestReliableSpoolingFileEventReader (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=91c58804da51a551fcbbe290261810c7750ee749)

        • flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #707 (See https://builds.apache.org/job/flume-trunk/707/ ) FLUME-2568 . Additional fix for TestReliableSpoolingFileEventReader (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=91c58804da51a551fcbbe290261810c7750ee749 ) flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Flume-trunk-hbase-98 #64 (See https://builds.apache.org/job/Flume-trunk-hbase-98/64/)
        FLUME-2568. Additional fix for TestReliableSpoolingFileEventReader (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=91c58804da51a551fcbbe290261810c7750ee749)

        • flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Flume-trunk-hbase-98 #64 (See https://builds.apache.org/job/Flume-trunk-hbase-98/64/ ) FLUME-2568 . Additional fix for TestReliableSpoolingFileEventReader (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=91c58804da51a551fcbbe290261810c7750ee749 ) flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java

          People

          • Assignee:
            jrufus Johny Rufus
            Reporter:
            jrufus Johny Rufus
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development