Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2466

Embedded agent name cannot contain spaces

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

        Activity

        Hide
        paliwalashish Ashish Paliwal added a comment -

        Hari Shreedharan Got it, I tried using " and ' like -n 'My agent', but shell passed only initial word. Good with the fix. Thanks!

        Show
        paliwalashish Ashish Paliwal added a comment - Hari Shreedharan Got it, I tried using " and ' like -n 'My agent', but shell passed only initial word. Good with the fix. Thanks!
        Hide
        hudson Hudson added a comment -

        UNSTABLE: Integrated in Flume-trunk-hbase-98 #28 (See https://builds.apache.org/job/Flume-trunk-hbase-98/28/)
        FLUME-2466. Embedded agent name cannot contain spaces (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9968f0fb00f8d25245067242a48040229952e46f)

        • flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java
        • flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java
        Show
        hudson Hudson added a comment - UNSTABLE: Integrated in Flume-trunk-hbase-98 #28 (See https://builds.apache.org/job/Flume-trunk-hbase-98/28/ ) FLUME-2466 . Embedded agent name cannot contain spaces (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9968f0fb00f8d25245067242a48040229952e46f ) flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #668 (See https://builds.apache.org/job/flume-trunk/668/)
        FLUME-2466. Embedded agent name cannot contain spaces (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9968f0fb00f8d25245067242a48040229952e46f)

        • flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java
        • flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #668 (See https://builds.apache.org/job/flume-trunk/668/ ) FLUME-2466 . Embedded agent name cannot contain spaces (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9968f0fb00f8d25245067242a48040229952e46f ) flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Correct, but being a command line argument, you can't have an agent with a space in the name (the shell will pass only the one before the space as the argument to the parameter). But in Embedded Agent, since the agent name is not explicitly specified in the channel/source/sink configs, the agent dies with an exception which does not even look related.

        Show
        hshreedharan Hari Shreedharan added a comment - Correct, but being a command line argument, you can't have an agent with a space in the name (the shell will pass only the one before the space as the argument to the parameter). But in Embedded Agent, since the agent name is not explicitly specified in the channel/source/sink configs, the agent dies with an exception which does not even look related.
        Hide
        paliwalashish Ashish Paliwal added a comment -

        Hari Shreedharan I debugged this and found the problem happens when MaterializedConfiguration is being created. I have not tested this, but suspect to have the same problem could manifest in normal flow if the agent name contains space. Correct me if I am wrong?

        Show
        paliwalashish Ashish Paliwal added a comment - Hari Shreedharan I debugged this and found the problem happens when MaterializedConfiguration is being created. I have not tested this, but suspect to have the same problem could manifest in normal flow if the agent name contains space. Correct me if I am wrong?
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed! Thanks Johny!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed! Thanks Johny!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6dbf51562e6c65ec8271b8b5ab44e5b0d269b1f8 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6dbf515 ]

        FLUME-2466. Embedded agent name cannot contain spaces

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6dbf51562e6c65ec8271b8b5ab44e5b0d269b1f8 in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=6dbf515 ] FLUME-2466 . Embedded agent name cannot contain spaces (Johny Rufus via Hari)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9968f0fb00f8d25245067242a48040229952e46f in flume's branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9968f0f ]

        FLUME-2466. Embedded agent name cannot contain spaces

        (Johny Rufus via Hari)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9968f0fb00f8d25245067242a48040229952e46f in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9968f0f ] FLUME-2466 . Embedded agent name cannot contain spaces (Johny Rufus via Hari)
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Committing

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Committing
        Hide
        jrufus Johny Rufus added a comment -

        The patch makes sure that the embedded flume agent uses names that doesn't contain spaces and if the name contains spaces it trims the name.

        Show
        jrufus Johny Rufus added a comment - The patch makes sure that the embedded flume agent uses names that doesn't contain spaces and if the name contains spaces it trims the name.

          People

          • Assignee:
            jrufus Johny Rufus
            Reporter:
            hshreedharan Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development