Flume
  1. Flume
  2. FLUME-2425

FileChannel should trim data and checkpoint directories

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.5.0.1
    • Fix Version/s: v1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Today if you place space in the CSV of data dirs you get odd results.

      1. FLUME-2425-1.patch
        2 kB
        Johny Rufus
      2. FLUME-2425.patch
        1 kB
        Johny Rufus

        Activity

        Hide
        Johny Rufus added a comment -

        Attached a patch with data and checkpoint directories trimmed.

        Show
        Johny Rufus added a comment - Attached a patch with data and checkpoint directories trimmed.
        Hide
        Brock Noland added a comment -

        I think we should use Guava Splitter here to omit empties and trim strings.

        Show
        Brock Noland added a comment - I think we should use Guava Splitter here to omit empties and trim strings.
        Hide
        Johny Rufus added a comment -

        Sure, used the Guava splitter, attaching FLUME-2425-1.patch

        Show
        Johny Rufus added a comment - Sure, used the Guava splitter, attaching FLUME-2425 -1.patch
        Hide
        Brock Noland added a comment -

        +1

        Show
        Brock Noland added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 42d8f95a89c180400abb665b421cf25f5cbc8380 in flume's branch refs/heads/flume-1.6 from Brock Noland
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=42d8f95 ]

        FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland)

        Show
        ASF subversion and git services added a comment - Commit 42d8f95a89c180400abb665b421cf25f5cbc8380 in flume's branch refs/heads/flume-1.6 from Brock Noland [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=42d8f95 ] FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland)
        Hide
        ASF subversion and git services added a comment -

        Commit 9e28ea671cf1baf86e26f468643f94141dc94323 in flume's branch refs/heads/trunk from Brock Noland
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9e28ea6 ]

        FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland)

        Show
        ASF subversion and git services added a comment - Commit 9e28ea671cf1baf86e26f468643f94141dc94323 in flume's branch refs/heads/trunk from Brock Noland [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=9e28ea6 ] FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland)
        Hide
        Brock Noland added a comment -

        Thank you so much for your contribution Johny! I have committed this to trunk and flume-1.6!!

        Show
        Brock Noland added a comment - Thank you so much for your contribution Johny! I have committed this to trunk and flume-1.6!!
        Hide
        Hudson added a comment -

        UNSTABLE: Integrated in flume-trunk #653 (See https://builds.apache.org/job/flume-trunk/653/)
        FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland) (brock: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9e28ea671cf1baf86e26f468643f94141dc94323)

        • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
        Show
        Hudson added a comment - UNSTABLE: Integrated in flume-trunk #653 (See https://builds.apache.org/job/flume-trunk/653/ ) FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland) (brock: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9e28ea671cf1baf86e26f468643f94141dc94323 ) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Flume-trunk-hbase-98 #13 (See https://builds.apache.org/job/Flume-trunk-hbase-98/13/)
        FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland) (brock: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9e28ea671cf1baf86e26f468643f94141dc94323)

        • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
        Show
        Hudson added a comment - FAILURE: Integrated in Flume-trunk-hbase-98 #13 (See https://builds.apache.org/job/Flume-trunk-hbase-98/13/ ) FLUME-2425 - FileChannel should trim data and checkpoint directories (Johny Rufus via Brock Noland) (brock: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=9e28ea671cf1baf86e26f468643f94141dc94323 ) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java

          People

          • Assignee:
            Johny Rufus
            Reporter:
            Brock Noland
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development