Flume
  1. Flume
  2. FLUME-2333

HTTP source handler doesn't allow for responses

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Existing HTTP source handlers recieve events via a HTTPServletRequest. This works, but because the handler doesn't have access to the HTTPServletResponse, there is no ability to return a response. This makes it unsuitable for some sort of protocol that relies on bidirectional communication.

      My solution: In addition to the existing HTTPSource interface, I've added a BidirectionalHTTPSource interface that is provided the servlet response as a parameter. I've made some changes in the HTTP source allow for both types to co-exist, and my changes shouldn't affect anyone who is already using the existing interface.

      Also includes minor documentation updates to reflect this.

      Review: https://reviews.apache.org/r/18555/

      1. FLUME-2333.diff
        37 kB
        Jeremy Karlson
      2. FLUME-2333-2.diff
        43 kB
        Gabriel Commeau
      3. FLUME-2333-3.diff
        46 kB
        Gabriel Commeau
      4. FLUME-2333-4.diff
        40 kB
        Gabriel Commeau
      5. FLUME-2333-CUMULATIVE.diff
        40 kB
        Jeremy Karlson

        Activity

        Jeremy Karlson created issue -
        Jeremy Karlson made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Jeremy Karlson [ karlj000 ]
        Jeremy Karlson made changes -
        Attachment FLUME-2333.diff [ 12631442 ]
        Jeremy Karlson made changes -
        Description Existing HTTP source handlers recieve events via a HTTPServletRequest. This works, but because the handler doesn't have access to the HTTPServletResponse, there is no ability to return a response. This makes it unsuitable for some sort of protocol that relies on bidirectional communication.

        My solution: In addition to the existing HTTPSource interface, I've added a BidirectionalHTTPSource interface that is provided the servlet response as a parameter. I've made some changes in the HTTP source allow for both types to co-exist, and my changes shouldn't affect anyone who is already using the existing interface.

        Also includes minor documentation updates to reflect this.
        Existing HTTP source handlers recieve events via a HTTPServletRequest. This works, but because the handler doesn't have access to the HTTPServletResponse, there is no ability to return a response. This makes it unsuitable for some sort of protocol that relies on bidirectional communication.

        My solution: In addition to the existing HTTPSource interface, I've added a BidirectionalHTTPSource interface that is provided the servlet response as a parameter. I've made some changes in the HTTP source allow for both types to co-exist, and my changes shouldn't affect anyone who is already using the existing interface.

        Also includes minor documentation updates to reflect this.

        Review: https://reviews.apache.org/r/18555/
        Gabriel Commeau made changes -
        Attachment FLUME-2333-2.diff [ 12631918 ]
        Gabriel Commeau made changes -
        Attachment FLUME-2333-3.diff [ 12634187 ]
        Gabriel Commeau made changes -
        Attachment FLUME-2333-4.diff [ 12634356 ]
        Jeremy Karlson made changes -
        Attachment FLUME-2333-CUMULATIVE.diff [ 12635140 ]

          People

          • Assignee:
            Jeremy Karlson
            Reporter:
            Jeremy Karlson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development