Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      One of the tests in the new DatasetSink can fail unexpectedly. It tests that the background process rolls the backing files correctly, waiting until the roller should have run and then reading the file. The part that fails is just after the initial call to process(), the test asserts that the records are not yet available. If for some reason the background thread has run and rolled the file, it will fail although everything works correctly.

      This was introduced when the rolling was changed to be proactive. Lazy rolling prevented a race.

        Activity

        Hide
        rdblue Ryan Blue added a comment -

        Patch to remove the bad assertion.

        Show
        rdblue Ryan Blue added a comment - Patch to remove the bad assertion.
        Hide
        hshreedharan Hari Shreedharan added a comment -

        +1. Running tests and committing

        Show
        hshreedharan Hari Shreedharan added a comment - +1. Running tests and committing
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 492cd8d08cab347e02e43805b47435413d16937c in branch refs/heads/trunk from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=492cd8d ]

        FLUME-2304. DatasetSink test fails unexpectedly.

        (Ryan Blue via Hari Shreedharan)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 492cd8d08cab347e02e43805b47435413d16937c in branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=492cd8d ] FLUME-2304 . DatasetSink test fails unexpectedly. (Ryan Blue via Hari Shreedharan)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 973f304634f3f3e0604468eaa84d5d445755cffd in branch refs/heads/flume-1.5 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=973f304 ]

        FLUME-2304. DatasetSink test fails unexpectedly.

        (Ryan Blue via Hari Shreedharan)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 973f304634f3f3e0604468eaa84d5d445755cffd in branch refs/heads/flume-1.5 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=973f304 ] FLUME-2304 . DatasetSink test fails unexpectedly. (Ryan Blue via Hari Shreedharan)
        Hide
        hshreedharan Hari Shreedharan added a comment -

        Committed. Thanks Ryan!

        Show
        hshreedharan Hari Shreedharan added a comment - Committed. Thanks Ryan!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in flume-trunk #542 (See https://builds.apache.org/job/flume-trunk/542/)
        FLUME-2304. DatasetSink test fails unexpectedly. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=492cd8d08cab347e02e43805b47435413d16937c)

        • flume-ng-sinks/flume-dataset-sink/src/test/java/org/apache/flume/sink/kite/TestDatasetSink.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in flume-trunk #542 (See https://builds.apache.org/job/flume-trunk/542/ ) FLUME-2304 . DatasetSink test fails unexpectedly. (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=492cd8d08cab347e02e43805b47435413d16937c ) flume-ng-sinks/flume-dataset-sink/src/test/java/org/apache/flume/sink/kite/TestDatasetSink.java

          People

          • Assignee:
            rdblue Ryan Blue
            Reporter:
            rdblue Ryan Blue
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development