Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2120

Capture Metrics to Monitor SyslogUDPSource and SyslogTCPSource

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.4.1
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      Need ability to track the number of events received and accepted for the SyslogUDPSource and SyslogTCPSource.

      1. FLUME-2120.4.patch
        20 kB
        Venkatesh Sivasubramanian
      2. FLUME-2120.patch
        11 kB
        Venkatesh Sivasubramanian

        Issue Links

          Activity

          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Pls. find the patch attached. I have made changes to SyslogUDPSource and SyslogTCPSource. Have also added a JUnit for SyslogUDPSource.

          I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was trivial and its very much a part of the code base.

          Pls. feel free to let me know if there any feedbacks or things to be taken care in this regard.

          Thanks!

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Pls. find the patch attached. I have made changes to SyslogUDPSource and SyslogTCPSource. Have also added a JUnit for SyslogUDPSource. I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was trivial and its very much a part of the code base. Pls. feel free to let me know if there any feedbacks or things to be taken care in this regard. Thanks!
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Sorry forgot to change the status earlier.

          Pls. find the patch attached. I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.

          I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was trivial and its very much a part of the code base.

          Pls. feel free to let me know if there any feedbacks or things to be taken care in this regard.

          Thanks!

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Sorry forgot to change the status earlier. Pls. find the patch attached. I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource. I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was trivial and its very much a part of the code base. Pls. feel free to let me know if there any feedbacks or things to be taken care in this regard. Thanks!
          Hide
          jlord Jeff Lord added a comment -

          Hi Venkatesh,

          Thank you for the patch and letting me know that FLUME-2205 is a duplicate of this issue.
          Are you able to create a review board link for this patch?

          Thank You,

          Jeff

          Show
          jlord Jeff Lord added a comment - Hi Venkatesh, Thank you for the patch and letting me know that FLUME-2205 is a duplicate of this issue. Are you able to create a review board link for this patch? Thank You, Jeff
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          No Jeff, I couldn't upload the file the last time I checked. Let me retry.

          Thanks
          Venkatesh

          Show
          venkyz Venkatesh Sivasubramanian added a comment - No Jeff, I couldn't upload the file the last time I checked. Let me retry. Thanks Venkatesh
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Jeff: I have created a review request and added the diff as "File attachment" in there. Unfortunately I couldn't upload it as diff as it says "No valid separator after the filename was found in the diff header" for some reason.

          Pls. feel free to let me know if I am missing something here.

          Thanks!

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Jeff: I have created a review request and added the diff as "File attachment" in there. Unfortunately I couldn't upload it as diff as it says "No valid separator after the filename was found in the diff header" for some reason. Pls. feel free to let me know if I am missing something here. Thanks!
          Hide
          jlord Jeff Lord added a comment -

          Venkatesh,

          Did you create your patch with the following command?
          git diff HEAD > FLUME-2120.x.patch

          This is what i use and it formats properly for rb.

          -J

          Show
          jlord Jeff Lord added a comment - Venkatesh, Did you create your patch with the following command? git diff HEAD > FLUME-2120 .x.patch This is what i use and it formats properly for rb. -J
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Yes Jeff! I ran that command (I do 'trunk' instead of 'Head', similar) and it generates the exact same file. I retried it in RB and same message there as well

          I have searched in a few forums before as well, quite a few people have this issue, no solution though. I think it is something to do with the version of Git (mine is 1.8.0).

          Thanks!

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Yes Jeff! I ran that command (I do 'trunk' instead of 'Head', similar) and it generates the exact same file. I retried it in RB and same message there as well I have searched in a few forums before as well, quite a few people have this issue, no solution though. I think it is something to do with the version of Git (mine is 1.8.0). Thanks!
          Hide
          jlord Jeff Lord added a comment -

          +1
          Ok. I am on 1.8.4
          Reviewed the patch and it looks good to me.
          One thing missing is the tcpsyslog source test though.
          I have added a test for that source on FLUME-1666 so will just need to add in the source counter test there as well.

          Show
          jlord Jeff Lord added a comment - +1 Ok. I am on 1.8.4 Reviewed the patch and it looks good to me. One thing missing is the tcpsyslog source test though. I have added a test for that source on FLUME-1666 so will just need to add in the source counter test there as well.
          Hide
          mpercy Mike Percy added a comment -

          Venkatesh: Make sure you are trying to attach it to flume-git repo in RB.

          Show
          mpercy Mike Percy added a comment - Venkatesh: Make sure you are trying to attach it to flume-git repo in RB.
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Ah, thanks Mike Percy! That was it! I have submitted a new request in RB with flume-git repo now.

          Jeff Lord: Great! Thank you.

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Ah, thanks Mike Percy ! That was it! I have submitted a new request in RB with flume-git repo now. Jeff Lord : Great! Thank you.
          Hide
          jlord Jeff Lord added a comment -

          Venkatesh Sivasubramanian
          Can you please attach the rb link to the jira here?

          Show
          jlord Jeff Lord added a comment - Venkatesh Sivasubramanian Can you please attach the rb link to the jira here?
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Jeff: Here you go. https://reviews.apache.org/r/14569/

          Thanks!

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Jeff: Here you go. https://reviews.apache.org/r/14569/ Thanks!
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Hi Mike/Jeff/Hari: Can you pls. help review this patch and let me know if you have any feedback? As you folks know, we have rebased it a few times already.

          Thanks you! I appreciate all your diligence.

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Hi Mike/Jeff/Hari: Can you pls. help review this patch and let me know if you have any feedback? As you folks know, we have rebased it a few times already. Thanks you! I appreciate all your diligence.
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Looks like the patch needs to be rebased. Could you please rebase? I will take a look at it as soon as you do. Thanks!

          Show
          hshreedharan Hari Shreedharan added a comment - Looks like the patch needs to be rebased. Could you please rebase? I will take a look at it as soon as you do. Thanks!
          Hide
          venkyz Venkatesh Sivasubramanian added a comment -

          Hi Hari: I have rebased the code and attached here and in review board.

          Thanks
          Venkatesh

          Show
          venkyz Venkatesh Sivasubramanian added a comment - Hi Hari: I have rebased the code and attached here and in review board. Thanks Venkatesh

            People

            • Assignee:
              venkyz Venkatesh Sivasubramanian
              Reporter:
              venkyz Venkatesh Sivasubramanian
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development