Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-2094

Remove the deprecated - Recoverable Memory Channel

    Details

    • Release Note:
      Removed Recoverable Memory Channel

      Description

      Dropping the deprecated 'Recoverable Memory Channel'

        Activity

        Hide
        roshan_naik Roshan Naik added a comment -

        Dropping recoverable memory channel

        Show
        roshan_naik Roshan Naik added a comment - Dropping recoverable memory channel
        Hide
        mpercy Mike Percy added a comment -

        Roshan, looks good. Could you please remove the RMC from the user guide doc as well?

        Show
        mpercy Mike Percy added a comment - Roshan, looks good. Could you please remove the RMC from the user guide doc as well?
        Hide
        roshan_naik Roshan Naik added a comment - - edited

        My bad.. thanks for catching it. Also dropping it from ChannelConfiguration.java ChannelType.java

        Show
        roshan_naik Roshan Naik added a comment - - edited My bad.. thanks for catching it. Also dropping it from ChannelConfiguration.java ChannelType.java
        Hide
        mpercy Mike Percy added a comment -

        Hi Roshan, thanks for the update but your patch deletes a bunch of files that it should not delete:

        $ git status
        # On branch trunk
        # Changes not staged for commit:
        #   (use "git add/rm <file>..." to update what will be committed)
        #   (use "git checkout -- <file>..." to discard changes in working directory)
        #
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/pom.xml
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java
        #	deleted:    flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties
        #	modified:   flume-ng-channels/pom.xml
        #	modified:   flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java
        #	modified:   flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java
        #	modified:   flume-ng-core/pom.xml
        #	deleted:    flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventDeserializer.java
        #	modified:   flume-ng-core/src/main/java/org/apache/flume/serialization/EventDeserializerType.java
        #	deleted:    flume-ng-core/src/main/java/org/apache/flume/serialization/LengthMeasurable.java
        #	deleted:    flume-ng-core/src/main/java/org/apache/flume/serialization/RemoteMarkable.java
        #	modified:   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java
        #	modified:   flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
        #	modified:   flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
        #	modified:   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java
        #	modified:   flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
        #	deleted:    flume-ng-core/src/test/java/org/apache/flume/serialization/TestAvroEventDeserializer.java
        #	deleted:    flume-ng-core/src/test/java/org/apache/flume/serialization/TransientPositionTracker.java
        #	modified:   flume-ng-dist/pom.xml
        #	modified:   flume-ng-dist/src/main/assembly/bin.xml
        #	modified:   flume-ng-doc/sphinx/FlumeUserGuide.rst
        #	modified:   pom.xml
        
        Show
        mpercy Mike Percy added a comment - Hi Roshan, thanks for the update but your patch deletes a bunch of files that it should not delete: $ git status # On branch trunk # Changes not staged for commit: # (use "git add/rm <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # deleted: flume-ng-channels/flume-recoverable-memory-channel/pom.xml # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties # modified: flume-ng-channels/pom.xml # modified: flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java # modified: flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java # modified: flume-ng-core/pom.xml # deleted: flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventDeserializer.java # modified: flume-ng-core/src/main/java/org/apache/flume/serialization/EventDeserializerType.java # deleted: flume-ng-core/src/main/java/org/apache/flume/serialization/LengthMeasurable.java # deleted: flume-ng-core/src/main/java/org/apache/flume/serialization/RemoteMarkable.java # modified: flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java # modified: flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java # modified: flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java # modified: flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java # modified: flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java # deleted: flume-ng-core/src/test/java/org/apache/flume/serialization/TestAvroEventDeserializer.java # deleted: flume-ng-core/src/test/java/org/apache/flume/serialization/TransientPositionTracker.java # modified: flume-ng-dist/pom.xml # modified: flume-ng-dist/src/main/assembly/bin.xml # modified: flume-ng-doc/sphinx/FlumeUserGuide.rst # modified: pom.xml
        Hide
        mpercy Mike Percy added a comment -

        Descoping from 1.4.0, not a blocker

        Show
        mpercy Mike Percy added a comment - Descoping from 1.4.0, not a blocker
        Hide
        roshan_naik Roshan Naik added a comment -

        which files are those ?

        Show
        roshan_naik Roshan Naik added a comment - which files are those ?
        Hide
        roshan_naik Roshan Naik added a comment -

        oops.. sorry.. yes i see it.. i think something got goofed up there.

        Show
        roshan_naik Roshan Naik added a comment - oops.. sorry.. yes i see it.. i think something got goofed up there.
        Hide
        roshan_naik Roshan Naik added a comment -

        Mistake in the git diff command used to generate the patch led to a busted patch. So the test run didnt catch it.

        Have verified this patch by applying it on vanilla flume-1.4 branch and then running tests.

        Mike.. my apologies. Owe you a beer for ur wasted weekend cycles on this !!

        Show
        roshan_naik Roshan Naik added a comment - Mistake in the git diff command used to generate the patch led to a busted patch. So the test run didnt catch it. Have verified this patch by applying it on vanilla flume-1.4 branch and then running tests. Mike.. my apologies. Owe you a beer for ur wasted weekend cycles on this !!
        Hide
        mpercy Mike Percy added a comment -

        +1, this looks good Roshan, thanks for the quick turnaround! I'll pull this into 1.4.

        Show
        mpercy Mike Percy added a comment - +1, this looks good Roshan, thanks for the quick turnaround! I'll pull this into 1.4.
        Hide
        mpercy Mike Percy added a comment -

        Pushed to trunk and flume-1.4 branches. Thanks for the patch Roshan!

        Show
        mpercy Mike Percy added a comment - Pushed to trunk and flume-1.4 branches. Thanks for the patch Roshan!
        Hide
        hudson Hudson added a comment -

        Integrated in flume-trunk #458 (See https://builds.apache.org/job/flume-trunk/458/)
        FLUME-2094. Remove the deprecated Recoverable Memory Channel. (Revision 08843202f78e0539e7ebb48c1d1a3fe7986db899)

        Result = SUCCESS
        mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=08843202f78e0539e7ebb48c1d1a3fe7986db899
        Files :

        • flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java
        • flume-ng-channels/flume-recoverable-memory-channel/pom.xml
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java
        • flume-ng-doc/sphinx/FlumeUserGuide.rst
        • flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties
        • pom.xml
        • flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java
        • flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java
        • flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java
        • flume-ng-dist/pom.xml
        • flume-ng-channels/pom.xml
        • flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java
        Show
        hudson Hudson added a comment - Integrated in flume-trunk #458 (See https://builds.apache.org/job/flume-trunk/458/ ) FLUME-2094 . Remove the deprecated Recoverable Memory Channel. (Revision 08843202f78e0539e7ebb48c1d1a3fe7986db899) Result = SUCCESS mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=08843202f78e0539e7ebb48c1d1a3fe7986db899 Files : flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java flume-ng-channels/flume-recoverable-memory-channel/pom.xml flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java flume-ng-doc/sphinx/FlumeUserGuide.rst flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties pom.xml flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java flume-ng-dist/pom.xml flume-ng-channels/pom.xml flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java

          People

          • Assignee:
            roshan_naik Roshan Naik
            Reporter:
            roshan_naik Roshan Naik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development