Roshan Naik added a comment - 19/Jun/13 02:42 Dropping recoverable memory channel

Mike Percy added a comment - 22/Jun/13 01:16 Roshan, looks good. Could you please remove the RMC from the user guide doc as well?

Roshan Naik added a comment - 22/Jun/13 23:10 - edited My bad.. thanks for catching it. Also dropping it from ChannelConfiguration.java ChannelType.java

Mike Percy added a comment - 23/Jun/13 08:32 Hi Roshan, thanks for the update but your patch deletes a bunch of files that it should not delete: $ git status # On branch trunk # Changes not staged for commit: # (use "git add/rm <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # deleted: flume-ng-channels/flume-recoverable-memory-channel/pom.xml # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java # deleted: flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties # modified: flume-ng-channels/pom.xml # modified: flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java # modified: flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java # modified: flume-ng-core/pom.xml # deleted: flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventDeserializer.java # modified: flume-ng-core/src/main/java/org/apache/flume/serialization/EventDeserializerType.java # deleted: flume-ng-core/src/main/java/org/apache/flume/serialization/LengthMeasurable.java # deleted: flume-ng-core/src/main/java/org/apache/flume/serialization/RemoteMarkable.java # modified: flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java # modified: flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java # modified: flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java # modified: flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java # modified: flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java # deleted: flume-ng-core/src/test/java/org/apache/flume/serialization/TestAvroEventDeserializer.java # deleted: flume-ng-core/src/test/java/org/apache/flume/serialization/TransientPositionTracker.java # modified: flume-ng-dist/pom.xml # modified: flume-ng-dist/src/main/assembly/bin.xml # modified: flume-ng-doc/sphinx/FlumeUserGuide.rst # modified: pom.xml

Mike Percy added a comment - 23/Jun/13 20:39 Descoping from 1.4.0, not a blocker

Roshan Naik added a comment - 24/Jun/13 03:29 which files are those ?

Roshan Naik added a comment - 24/Jun/13 03:31 oops.. sorry.. yes i see it.. i think something got goofed up there.

Roshan Naik added a comment - 24/Jun/13 04:15 Mistake in the git diff command used to generate the patch led to a busted patch. So the test run didnt catch it. Have verified this patch by applying it on vanilla flume-1.4 branch and then running tests. Mike.. my apologies. Owe you a beer for ur wasted weekend cycles on this !!

Mike Percy added a comment - 24/Jun/13 07:36 +1, this looks good Roshan, thanks for the quick turnaround! I'll pull this into 1.4.

Mike Percy added a comment - 24/Jun/13 07:44 Pushed to trunk and flume-1.4 branches. Thanks for the patch Roshan!

Hudson added a comment - 24/Jun/13 08:47 Integrated in flume-trunk #458 (See https://builds.apache.org/job/flume-trunk/458/ ) FLUME-2094 . Remove the deprecated Recoverable Memory Channel. (Revision 08843202f78e0539e7ebb48c1d1a3fe7986db899) Result = SUCCESS mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=08843202f78e0539e7ebb48c1d1a3fe7986db899 Files : flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java flume-ng-channels/flume-recoverable-memory-channel/pom.xml flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java flume-ng-doc/sphinx/FlumeUserGuide.rst flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties pom.xml flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java flume-ng-dist/pom.xml flume-ng-channels/pom.xml flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java