Flume
  1. Flume
  2. FLUME-2040

Configurable periodically polling for the config file would be nice

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: v1.4.0
    • Fix Version/s: None
    • Component/s: Configuration
    • Labels:
      None

      Description

      Flume periodically polling for changes to the config file is default set to 30 seconds, but it's not configurable. It would be nice to be configurable.

      Hard coded in: ./flume-ng-node/src/main/java/org/apache/flume/node/Application.java

      PollingPropertiesFileConfigurationProvider configurationProvider =
          new PollingPropertiesFileConfigurationProvider(agentName,
              configurationFile, eventBus, 30);
      
      1. FLUME-2040-1.patch
        2 kB
        Jongyeol Choi
      2. FLUME-2040-3.patch
        2 kB
        Jongyeol Choi

        Issue Links

          Activity

          Hide
          Jongyeol Choi added a comment -

          Uploaded patch is malformed. I reattached FLUME-2040-3.patch.

          Show
          Jongyeol Choi added a comment - Uploaded patch is malformed. I reattached FLUME-2040 -3.patch.
          Hide
          Jongyeol Choi added a comment -

          I agree. I attached an extended patch. If reload-conf is zero or negative, disable auto reloading.

          Show
          Jongyeol Choi added a comment - I agree. I attached an extended patch. If reload-conf is zero or negative, disable auto reloading.
          Hide
          Alexander Alten-Lorenz added a comment -

          Could you extend the patch in the way that the polling can be disabled too? As example, when the content of --reload-conf are 0 no polling will be used.

          Show
          Alexander Alten-Lorenz added a comment - Could you extend the patch in the way that the polling can be disabled too? As example, when the content of --reload-conf are 0 no polling will be used.
          Hide
          Jongyeol Choi added a comment -

          When start()/stop() of custom source/sink needs more than 30 seconds, it may needs polling() configurable to prevent too early start()/stop().

          Show
          Jongyeol Choi added a comment - When start()/stop() of custom source/sink needs more than 30 seconds, it may needs polling() configurable to prevent too early start()/stop().
          Hide
          Alexander Alten-Lorenz added a comment -

          Whats the use case to make polling() configurable? I could imagine to en-/disable the option for security reasons (preventing injection of unwanted config changes).

          Thanks

          Show
          Alexander Alten-Lorenz added a comment - Whats the use case to make polling() configurable? I could imagine to en-/disable the option for security reasons (preventing injection of unwanted config changes). Thanks
          Hide
          Jongyeol Choi added a comment -

          Yes, this is optional. This patch keeps the default value to 30 if not exists reload-conf option.

          Show
          Jongyeol Choi added a comment - Yes, this is optional. This patch keeps the default value to 30 if not exists reload-conf option.
          Hide
          Lenin Raj Rajasekaran added a comment -

          Is this optional? I mean can we leave the default to 30 seconds?

          Show
          Lenin Raj Rajasekaran added a comment - Is this optional? I mean can we leave the default to 30 seconds?
          Hide
          Jongyeol Choi added a comment -

          I attached a simple patch for this issue.

          Show
          Jongyeol Choi added a comment - I attached a simple patch for this issue.

            People

            • Assignee:
              Unassigned
              Reporter:
              Daisuke Kobayashi
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:

                Development