Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v0.9.2
    • Component/s: Master, Node, Shell, Sinks+Sources
    • Labels:
      None

      Description

      Thrift-0.4.0 has come up in 3 weeks after Thrift 0.3.0, we patched the apis that were different.
      We tested on wire compatibility.

        Issue Links

          Activity

          Hide
          Dani Abel Rayan added a comment -

          This patch upgrades flume to work with thrift-0.4.0

          Show
          Dani Abel Rayan added a comment - This patch upgrades flume to work with thrift-0.4.0
          Hide
          Dani Abel Rayan added a comment -

          this patch resolves the mismatch between ByteBuffer and Byte Array.

          Show
          Dani Abel Rayan added a comment - this patch resolves the mismatch between ByteBuffer and Byte Array.
          Hide
          Dani Abel Rayan added a comment -

          This patch updates all files together

          Show
          Dani Abel Rayan added a comment - This patch updates all files together
          Hide
          Jonathan Hsieh added a comment -

          There are some thrift related issues being hashed out with the cassandra plugin (because it embeds parts of cassandra). My first thought is that flume should just move forward to the most recent official thrift version and punt on the version clash issues in plugins for now.

          Show
          Jonathan Hsieh added a comment - There are some thrift related issues being hashed out with the cassandra plugin (because it embeds parts of cassandra). My first thought is that flume should just move forward to the most recent official thrift version and punt on the version clash issues in plugins for now.
          Hide
          Jonathan Hsieh added a comment -

          The version class issues have been resolved on the cassandra side (FLUME-20). Essentially there needs to be a different cassandra plugin version depending on the version of thrift being used in flume and it will use the same lib as flume.

          Show
          Jonathan Hsieh added a comment - The version class issues have been resolved on the cassandra side ( FLUME-20 ). Essentially there needs to be a different cassandra plugin version depending on the version of thrift being used in flume and it will use the same lib as flume.
          Hide
          Jonathan Hsieh added a comment -

          Dani,
          Our continuous integration environment cannot handle this patch yet due to changes in the node-master protocol from the recently committed FLUME-182. Could you do a rebase and regen the auto-generated 0.4.0 thrift code? I think the update will be nearly trivial.

          Thanks,
          Jon.

          Show
          Jonathan Hsieh added a comment - Dani, Our continuous integration environment cannot handle this patch yet due to changes in the node-master protocol from the recently committed FLUME-182 . Could you do a rebase and regen the auto-generated 0.4.0 thrift code? I think the update will be nearly trivial. Thanks, Jon.
          Hide
          Dani Abel Rayan added a comment -

          Jon,
          Should I push the generated code in github ?
          -Dani

          Show
          Dani Abel Rayan added a comment - Jon, Should I push the generated code in github ? -Dani
          Hide
          Jonathan Hsieh added a comment -

          I've updated the patch to fix a few things due to intervening patches.

          Currently having a problem uploading new patches.

          committed

          Show
          Jonathan Hsieh added a comment - I've updated the patch to fix a few things due to intervening patches. Currently having a problem uploading new patches. committed
          Hide
          Jonathan Hsieh added a comment -

          Closing released issues.

          Show
          Jonathan Hsieh added a comment - Closing released issues.

            People

            • Assignee:
              Dani Abel Rayan
              Reporter:
              Dani Abel Rayan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development