Phil, in addition to the wiki link from Hari above, you can follow the steps below to create a review for the patch.
Check first to make sure that it follows the formatting guidelines and recommendations specified in the wiki page.
I will be updating the wiki page soon with these steps but in the time being, here are the steps for submitting the review for this patch:
(1) Get the latest code from GIT
git clone http://git-wip-us.apache.org/repos/asf/flume.git flume
git checkout flume-1.4
The current branch for the next release is flume-1.4; this is why we are using "flume-1.4".
(2) Apply your changes to the code you have checked out
(3) Try to compile the code changes, create a tarball and run the unit tests to make sure that all is well with your changes
mvn clean install
It is very important to test the changes to make sure the work satisfactorily before submitting the patch
So you can configure the generated tarball and run it to see if it works for you first
(4) If all is well, then create the patches:
git diff --no-prefix > /path/to/
Use the JIRA issue ID for the patch files you generate.
If you have more than one pending patch (for different issues) to submit, you can specify the path to the file or directory where the changes are
git diff --no-prefix flume-ng-core/src/main/java/org/apache/flume/serialization/LineDeserializer.java > /path/to/
git diff --no-prefix flume-ng-doc/sphinx/Flume* > /path/to/
git diff --no-prefix flume-ng-core/src/main/java/org/apache/flume/sink/ > /path/to/
(5) Upload the patche file(s) to the JIRA issue and set the status to PATCH AVAILABLE.
(6) Create a review for your patch files here:
Pick "flume-git" as the repository and "Flume" as the group. The current branch is "flume-1.4"
(7) You can take a look at other code reviews here for some examples:
Thank you for your contribution