Flume
  1. Flume
  2. FLUME-1869

Request to add "HTTP" source type to SourceType.java

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.4.0
    • Fix Version/s: v1.4.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      Request "HTTP" source type so that user doesn't need to specify FQCN in for HTTPSource in config file.

      1. FLUME-1869.patch
        2 kB
        Hari Shreedharan
      2. FLUME-1869-1.patch
        3 kB
        Hari Shreedharan

        Activity

        Hide
        Hari Shreedharan added a comment -

        Trivial patch, skipping RB

        Show
        Hari Shreedharan added a comment - Trivial patch, skipping RB
        Hide
        Juhani Connolly added a comment -

        Looks fine. Do you think you could also update the docs?
        Something like

        -*type* The FQCN of this class: ``org.apache.flume.source.http.HTTPSource``
        +*type* The component type name, needs to be: ``http``

        Show
        Juhani Connolly added a comment - Looks fine. Do you think you could also update the docs? Something like -* type * The FQCN of this class: ``org.apache.flume.source.http.HTTPSource`` +* type * The component type name, needs to be: ``http``
        Hide
        Hari Shreedharan added a comment -

        Thanks Juhani. Updated patch with docs changes.

        Show
        Hari Shreedharan added a comment - Thanks Juhani. Updated patch with docs changes.
        Hide
        Juhani Connolly added a comment -

        Looks good

        I meant to commit this but I'm getting an error with the auth, so go ahead and push it.

        [juhanic@localhost flume]$ git push --dry-run
        error: no DAV locking support on https://git-wip-us.apache.org/repos/asf/flume.git/

        I haven't pushed stuff for a while, did something change? Also we should probably reflect the policy of committing to both trunk and the active development branch here: https://cwiki.apache.org/confluence/display/FLUME/How+to+Commit

        Show
        Juhani Connolly added a comment - Looks good I meant to commit this but I'm getting an error with the auth, so go ahead and push it. [juhanic@localhost flume] $ git push --dry-run error: no DAV locking support on https://git-wip-us.apache.org/repos/asf/flume.git/ I haven't pushed stuff for a while, did something change? Also we should probably reflect the policy of committing to both trunk and the active development branch here: https://cwiki.apache.org/confluence/display/FLUME/How+to+Commit
        Hide
        Hari Shreedharan added a comment -

        Juhani Connolly This is likely because you have not set up authentication correctly: https://git-wip-us.apache.org/docs/common-errors.html

        If you still can't push, I will push it. Thanks!

        Show
        Hari Shreedharan added a comment - Juhani Connolly This is likely because you have not set up authentication correctly: https://git-wip-us.apache.org/docs/common-errors.html If you still can't push, I will push it. Thanks!
        Hide
        Juhani Connolly added a comment -

        Wasn't that... I did try it just in case, but still borked. I'm sure I'll figure it out later. Go ahead and push it.

        Show
        Juhani Connolly added a comment - Wasn't that... I did try it just in case, but still borked. I'm sure I'll figure it out later. Go ahead and push it.
        Hide
        Brock Noland added a comment -

        Committed to trunk and 1.4! Thanks Hari!

        Show
        Brock Noland added a comment - Committed to trunk and 1.4! Thanks Hari!
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #355 (See https://builds.apache.org/job/flume-trunk/355/)
        FLUME-1869: Request to add 'HTTP' source type to SourceType.java (Revision 07f4516f2d7d703cf1f79bc47624576bf8de9af2)

        Result = SUCCESS
        brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=07f4516f2d7d703cf1f79bc47624576bf8de9af2
        Files :

        • flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
        • flume-ng-doc/sphinx/FlumeUserGuide.rst
        • flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java
        Show
        Hudson added a comment - Integrated in flume-trunk #355 (See https://builds.apache.org/job/flume-trunk/355/ ) FLUME-1869 : Request to add 'HTTP' source type to SourceType.java (Revision 07f4516f2d7d703cf1f79bc47624576bf8de9af2) Result = SUCCESS brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=07f4516f2d7d703cf1f79bc47624576bf8de9af2 Files : flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java flume-ng-doc/sphinx/FlumeUserGuide.rst flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java

          People

          • Assignee:
            Hari Shreedharan
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development