Flume
  1. Flume
  2. FLUME-1796

Upgrade Thrift due to race condition in TThreadSeverPool

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: v1.3.0
    • Fix Version/s: None
    • Component/s: Test
    • Labels:
      None
    • Environment:

      RHEL 5.x based systems, some SUSE versions

      Description

      While running the Flume unit tests, I observed that under some Linux environments (RHEL 5.x based etc), the Flume thrift source tests were timing out. This is because of a race condition in TThreadPoolServer used by Flume and speicifically in the testlifecycle. I have created a JIRA issue on Thrift regarding this[1]. I have creaed this issue, just so that we cross reference it here.

      [1] THRIFT-1795 - Race condition in TThreadedServerPool java implementation,

      1. FLUME-1796.patch
        6 kB
        Venkat Ranganathan

        Issue Links

          Activity

          Venkat Ranganathan created issue -
          Brock Noland made changes -
          Field Original Value New Value
          Link This issue is a clone of FLUME-1788 [ FLUME-1788 ]
          Brock Noland made changes -
          Link This issue relates to THRIFT-1795 [ THRIFT-1795 ]
          Hide
          Venkat Ranganathan added a comment - - edited

          Now that thrift 0.9.1 has been release, I have updated the dependencies and also fixed a few lines of code where access was overridden (made methods public instead of protected) and provided a default implementation of isOneWay() to return false.

          Also undid the workaround introduced earlier

          Built and ran tests with these changes

          Show
          Venkat Ranganathan added a comment - - edited Now that thrift 0.9.1 has been release, I have updated the dependencies and also fixed a few lines of code where access was overridden (made methods public instead of protected) and provided a default implementation of isOneWay() to return false. Also undid the workaround introduced earlier Built and ran tests with these changes
          Venkat Ranganathan made changes -
          Attachment FLUME-1796.patch [ 12627462 ]
          Venkat Ranganathan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hari Shreedharan added a comment -

          We should make sure we use comparable thrift versions as our dependencies. HBase has a dependency on thrift. At this point, we can bump our version minimum for hbase to 0.94.x

          Show
          Hari Shreedharan added a comment - We should make sure we use comparable thrift versions as our dependencies. HBase has a dependency on thrift. At this point, we can bump our version minimum for hbase to 0.94.x
          Hide
          Venkat Ranganathan added a comment -

          Hari Shreedharan is it time to revisit this. HBase has moved on to new versions.

          Show
          Venkat Ranganathan added a comment - Hari Shreedharan is it time to revisit this. HBase has moved on to new versions.
          Hide
          Hari Shreedharan added a comment -

          Venkat Ranganathan - Sounds good. Can you update the minimum require Hbase versions too?

          Show
          Hari Shreedharan added a comment - Venkat Ranganathan - Sounds good. Can you update the minimum require Hbase versions too?
          Hide
          Roshan Naik added a comment -

          Venkat Ranganathan do not change the min hbase version. flume is switching its hbase version to 1.0

          Show
          Roshan Naik added a comment - Venkat Ranganathan do not change the min hbase version. flume is switching its hbase version to 1.0
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          415d 2h 36m 1 Venkat Ranganathan 06/Feb/14 20:45

            People

            • Assignee:
              Venkat Ranganathan
              Reporter:
              Venkat Ranganathan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development