Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: v1.3.0
-
Fix Version/s: v1.4.0
-
Component/s: None
-
Labels:None
Description
file-channel, core, thrift legacy source, elastic source, and hbase sink.
Issue Links
- links to
Activity
Commons-lang is a pretty stable library with functionality we could probably use. I am going to add it to the poms where it's absent but used.
Show
Brock Noland
added a comment - Commons-lang is a pretty stable library with functionality we could probably use. I am going to add it to the poms where it's absent but used.
Where it's used:
$ find . -name '*.java' | xargs grep org.apache.commons.lang ./flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java:import org.apache.commons.lang.ArrayUtils; ./flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptor.java:import org.apache.commons.lang.StringUtils; ./flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptorMillisSerializer.java:import org.apache.commons.lang.StringUtils; ./flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEvent.java:import org.apache.commons.lang.builder.HashCodeBuilder; ./flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java:import org.apache.commons.lang.builder.HashCodeBuilder; ./flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java:import org.apache.commons.lang.StringUtils; ./flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java:import org.apache.commons.lang.StringUtils; ./flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java:import org.apache.commons.lang.time.FastDateFormat; ./flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/RegexHbaseEventSerializer.java:import org.apache.commons.lang.RandomStringUtils;
Show
Brock Noland
added a comment - Where it's used:
$ find . -name '*.java' | xargs grep org.apache.commons.lang
./flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java:import org.apache.commons.lang.ArrayUtils;
./flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptor.java:import org.apache.commons.lang.StringUtils;
./flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptorMillisSerializer.java:import org.apache.commons.lang.StringUtils;
./flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEvent.java:import org.apache.commons.lang.builder.HashCodeBuilder;
./flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java:import org.apache.commons.lang.builder.HashCodeBuilder;
./flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java:import org.apache.commons.lang.StringUtils;
./flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java:import org.apache.commons.lang.StringUtils;
./flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java:import org.apache.commons.lang.time.FastDateFormat;
./flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/RegexHbaseEventSerializer.java:import org.apache.commons.lang.RandomStringUtils;
+1. Running tests, will commit once done.
Show
Hari Shreedharan
added a comment - +1. Running tests, will commit once done.
Patch committed, rev: bdcad923e5f5aaf157c43a9f84e8c36c2f84171a. Thanks Brock!
Show
Hari Shreedharan
added a comment - Patch committed, rev: bdcad923e5f5aaf157c43a9f84e8c36c2f84171a. Thanks Brock!
Integrated in flume-trunk #339 (See https://builds.apache.org/job/flume-trunk/339/)
FLUME-1776. Several modules require commons-lang but do not declare this in the pom (Revision bdcad923e5f5aaf157c43a9f84e8c36c2f84171a)
Result = SUCCESS
hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=bdcad923e5f5aaf157c43a9f84e8c36c2f84171a
Files :
- flume-ng-core/pom.xml
- flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml
- flume-ng-legacy-sources/flume-thrift-source/pom.xml
- flume-ng-sinks/flume-ng-hbase-sink/pom.xml
Show
Hudson
added a comment - Integrated in flume-trunk #339 (See https://builds.apache.org/job/flume-trunk/339/ )
FLUME-1776 . Several modules require commons-lang but do not declare this in the pom (Revision bdcad923e5f5aaf157c43a9f84e8c36c2f84171a)
Result = SUCCESS
hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=bdcad923e5f5aaf157c43a9f84e8c36c2f84171a
Files :
flume-ng-core/pom.xml
flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml
flume-ng-legacy-sources/flume-thrift-source/pom.xml
flume-ng-sinks/flume-ng-hbase-sink/pom.xml
The uses of this package are very small. It might be nice to remove this dependency.