Flume
  1. Flume
  2. FLUME-1763

FileChannel Checkpoints should not be done without free space

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.3.0
    • Fix Version/s: v1.3.1
    • Component/s: Channel
    • Labels:
      None

      Description

      We should not do a checkpoint if we do't have sufficient free space. The same approach as FLUME-1609 can be taken.

      1. FLUME-1763-1.patch
        14 kB
        Brock Noland
      2. FLUME-1763-2.patch
        14 kB
        Brock Noland
      3. FLUME-1763-3.patch
        14 kB
        Brock Noland
      4. FLUME-1763-4.patch
        14 kB
        Brock Noland

        Issue Links

          Activity

          Brock Noland created issue -
          Brock Noland made changes -
          Field Original Value New Value
          Link This issue relates to FLUME-1609 [ FLUME-1609 ]
          Hide
          Brock Noland added a comment -

          We should also:

          1) Make that number configurable.
          2) Increase the default to 100MB

          Show
          Brock Noland added a comment - We should also: 1) Make that number configurable. 2) Increase the default to 100MB
          Hide
          Brock Noland added a comment -

          Note that although the checkpoint file itself is pre-allocated, the meta data file is not.

          Show
          Brock Noland added a comment - Note that although the checkpoint file itself is pre-allocated, the meta data file is not.
          Brock Noland made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Brock Noland [ brocknoland ]
          Brock Noland made changes -
          Remote Link This issue links to "Review Board (Web Link)" [ 11601 ]
          Hide
          Brock Noland added a comment -

          Patch attached

          Show
          Brock Noland added a comment - Patch attached
          Brock Noland made changes -
          Attachment FLUME-1763-1.patch [ 12559640 ]
          Brock Noland made changes -
          Attachment FLUME-1763-2.patch [ 12559645 ]
          Hide
          Brock Noland added a comment -

          Latest patch attached.

          Show
          Brock Noland added a comment - Latest patch attached.
          Brock Noland made changes -
          Attachment FLUME-1763-3.patch [ 12560305 ]
          Hide
          Brock Noland added a comment -

          LAtest

          Show
          Brock Noland added a comment - LAtest
          Brock Noland made changes -
          Attachment FLUME-1763-4.patch [ 12560323 ]
          Hide
          Hari Shreedharan added a comment -

          +1.

          Show
          Hari Shreedharan added a comment - +1.
          Hide
          Hari Shreedharan added a comment -

          Patch committed, rev: 806a7b6ace9398de2645f073acc72de19913bfab. Thanks Brock!

          Show
          Hari Shreedharan added a comment - Patch committed, rev: 806a7b6ace9398de2645f073acc72de19913bfab. Thanks Brock!
          Hari Shreedharan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #339 (See https://builds.apache.org/job/flume-trunk/339/)
          FLUME-1763. FileChannel checkpoints should not be done without free space (Revision 806a7b6ace9398de2645f073acc72de19913bfab)

          Result = SUCCESS
          hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=806a7b6ace9398de2645f073acc72de19913bfab
          Files :

          • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java
          • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
          • flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
          • flume-ng-doc/sphinx/FlumeUserGuide.rst
          • flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java
          Show
          Hudson added a comment - Integrated in flume-trunk #339 (See https://builds.apache.org/job/flume-trunk/339/ ) FLUME-1763 . FileChannel checkpoints should not be done without free space (Revision 806a7b6ace9398de2645f073acc72de19913bfab) Result = SUCCESS hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=806a7b6ace9398de2645f073acc72de19913bfab Files : flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java flume-ng-doc/sphinx/FlumeUserGuide.rst flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java
          Brock Noland made changes -
          Link This issue is related to FLUME-1794 [ FLUME-1794 ]
          Hari Shreedharan made changes -
          Fix Version/s v1.3.1 [ 12323879 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          5d 5h 38m 1 Brock Noland 06/Dec/12 21:52
          Patch Available Patch Available Resolved Resolved
          4d 3h 22m 1 Hari Shreedharan 11/Dec/12 01:15

            People

            • Assignee:
              Brock Noland
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development